Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH-272] Make mpyl work in the monorepo #96

Merged
merged 26 commits into from
May 15, 2023
Merged

[TECH-272] Make mpyl work in the monorepo #96

merged 26 commits into from
May 15, 2023

Conversation

SamTheisens
Copy link
Collaborator

@SamTheisens SamTheisens commented May 10, 2023 •
edited
Loading

Corresponding monorepo changes https://github.com/Vandebron/Vandebron/pull/10358

branch: feature/TECH-272-upgrade-monorepo

@SamTheisens
[TECH-272] Pull main at start of run
144708c 
branch: feature/TECH-272-upgrade-monorepo
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Test Results

66 tests   64 ✔️  9s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 5291fb8.

♻️ This comment has been updated with latest results.

@SamTheisens
[TECH-272] Log url of origin
5da482a 
branch: feature/TECH-272-upgrade-monorepo
@vandebronjenkins
Copy link

vandebronjenkins commented May 10, 2023 •
edited by jira bot
Loading

📕 TECH-272 Investigate and fix monorepo runner sam@vandebron.nl

Figure out a better way to run mpyl on the monorepo
🏗️ Build 17 ✅ Successful, started by Sam Theisens
🚀 enrichChargeSessionsJob, job, kong-sync, nodeservice, sbtservice

@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from 6fe615e to 9797293 Compare May 10, 2023 07:01
@SamTheisens
[TECH-272] No results is considered a success
f34167e 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Only pull main if necessary
0780018 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Show message when nothing was done
8f8004b 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from d01d895 to 8f8004b Compare May 10, 2023 09:34
@SamTheisens SamTheisens changed the title [TECH-272] Pull main at start of run [TECH-272] Make mpyl work in the monorepo May 11, 2023
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from 564fe64 to bbc2ce3 Compare May 12, 2023 06:24
@SamTheisens SamTheisens marked this pull request as ready for review May 12, 2023 15:24
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from 40a5af0 to 621c1a3 Compare May 12, 2023 15:45
@SamTheisens SamTheisens requested a review from koeves May 15, 2023 05:47
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch 2 times, most recently from ba7e769 to cea8341 Compare May 15, 2023 06:38
SamTheisens added 12 commits May 15, 2023 14:46
@SamTheisens
[TECH-272] Introduce default ingres routes for services
ccd3c63 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Fix client mode
bb9215d 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Pass on dry run parameter in runner
5cd8556 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Use release name instead of project name
8bb4de7 
to avoid:
```
a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
```

branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Include default restart policy
314cec9 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Log ingress route if present
7a06f00 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Replace dummy with real port
6a8e188 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Rename using single f
06240e5 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Emit middleware as part of deployment
a37b8ee 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Add schema for middleware
86ae4e0 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Add support for ip range whitelists
9f3e2f7 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Allow for empty description
7e33bb9 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Fix link to pull request
2f693b5 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Add link to deployed service
3202b49 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Introduce separate command for client mode
85e3b55 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Improve exception handling and reporting
274dbfd 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Decode logs with original encoding
05dc610 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Fix regex match for links
0426623 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from cea8341 to 0426623 Compare May 15, 2023 06:48
Jorg88
Jorg88 reviewed May 15, 2023
View reviewed changes
src/mpyl/reporting/formatting/markdown.py Outdated Show resolved Hide resolved
src/mpyl/reporting/formatting/markdown.py Outdated Show resolved Hide resolved
src/mpyl/steps/deploy/k8s/chart.py Show resolved Hide resolved
src/mpyl/steps/deploy/k8s/resources/schema/traeffik.ingress.schema.yml Outdated Show resolved Hide resolved
src/mpyl/steps/deploy/k8s/resources/schema/traeffik.middleware.schema.yml Outdated Show resolved Hide resolved
src/mpyl/steps/deploy/k8s/resources/treafik.py Outdated Show resolved Hide resolved
src/mpyl/utilities/jenkins/runner.py Show resolved Hide resolved
@Vandebron Vandebron deleted a comment from Jorg88 May 15, 2023
@SamTheisens
[TECH-272] Simplify result markdown logic
fae82c3 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens
[TECH-272] Rename double f to single f traefik
adfd3d4 
branch: feature/TECH-272-upgrade-monorepo
@SamTheisens SamTheisens force-pushed the feature/TECH-272-upgrade-monorepo branch from be4cc6d to adfd3d4 Compare May 15, 2023 07:59
@SamTheisens
[TECH-272] Rename misspelt traefik
5291fb8 
branch: feature/TECH-272-upgrade-monorepo
@github-actions
Copy link

Code Coverage

Package Line Rate Health
src.mpyl 92% ➖
src.mpyl.cli 56% ❌
src.mpyl.cli.commands 100% ✔
src.mpyl.cli.commands.build 40% ❌
src.mpyl.cli.commands.health 27% ❌
src.mpyl.cli.commands.projects 37% ❌
src.mpyl.projects 94% ➖
src.mpyl.reporting 100% ✔
src.mpyl.reporting.formatting 99% ➖
src.mpyl.reporting.targets 57% ❌
src.mpyl.stages 77% ➖
src.mpyl.steps 91% ➖
src.mpyl.steps.build 58% ❌
src.mpyl.steps.deploy 68% ❌
src.mpyl.steps.deploy.k8s 88% ➖
src.mpyl.steps.deploy.k8s.resources 96% ➖
src.mpyl.steps.test 49% ❌
src.mpyl.utilities 100% ✔
src.mpyl.utilities.docker 61% ❌
src.mpyl.utilities.ephemeral 75% ➖
src.mpyl.utilities.github 55% ❌
src.mpyl.utilities.jenkins 36% ❌
src.mpyl.utilities.junit 92% ➖
src.mpyl.utilities.pyaml_env 100% ✔
src.mpyl.utilities.repo 61% ❌
src.mpyl.utilities.sbt 96% ➖
src.mpyl.utilities.subprocess 92% ➖
Summary 71% (1912 / 2686) ➖

Minimum allowed line rate is 70%

@SamTheisens SamTheisens requested a review from Jorg88 May 15, 2023 08:19
@SamTheisens SamTheisens merged commit 93be69d into main May 15, 2023
@SamTheisens SamTheisens deleted the feature/TECH-272-upgrade-monorepo branch May 15, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewaldschrader ewaldschrader Awaiting requested review from ewaldschrader

@koeves koeves Awaiting requested review from koeves

@Jorg88 Jorg88 Awaiting requested review from Jorg88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamTheisens @vandebronjenkins @Jorg88