Potential Audio Fix for Windows #1068
Conversation
Key modifications: Added Windows-specific audio handling - Included path-based app name detection - Prepared structure for virtual audio cable routing - Added placeholder for audio routing constraints Note: Precise virtual audio cable implementation requires platform-specific audio routing libraries or APIs. You may need to integrate additional Windows audio routing mechanisms.
Added in the copyright (I accidently removed) added in integration for windows. New Key features: - Advanced audio routing for Windows - Virtual audio device detection - Configurable excluded processes - Fallback mechanisms - Cross-platform support with Wayland handling
Key changes made: Organized imports into three groups: External dependencies (electron) Node.js built-in modules (child_process, path) Internal project imports (renderer, shared, utils) Replaced all single quotes with double quotes for consistency: String literals Import statements Object properties Console messages Removed unused path import (though kept it in the same position in case it's needed later) Added proper spacing between imports and the rest of the code
|
my apologies, I am still newish to typescript lmao, these changes should have fixed it |
|
Thank you for your contribution! This PR confuses me though. You mention setting up a Virtual Cable but the code does not do this in any way. It just looks it up in the existing audio devices. Is this a thing that always exists on Windows? Also please do not make random changes to lint settings or unrelated files |
VB cable isn't open source so it requires you to have it installed separately. When the program is loaded, it creates an output and that what he is looking up. @CloveTwilight3 |
Branching off this, VB cable is the think I'm looking up, as not open source, but most people will download the software as a windows user. RE the manual setup, if its automated, that removes faff, but also making it manually should not conflict with anything, so either option should be good to use |
Agreed with what @quadrinex says. Also apologies for the lint settings changes, just a habit of mine to do tweaks like that 😅 |
|
So will it be merged? |
Potential fix for issue 569
As mentioned by @quadrinex, we can setup a virtual cable and exclude the "vesktop.exe" executable from this.