Remove parameter hashing from unsupported tfm (#920)

* remove parameter hashing from unsupported TFM * .
VerifyTests · Jun 20, 2023 · 226e6a0 · 226e6a0
1 parent 4cde1d9
commit 226e6a0
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 2 deletions.
diff --git a/src/Verify.Tests/Naming/NamerTests.cs b/src/Verify.Tests/Naming/NamerTests.cs
@@ -586,6 +586,7 @@ public Task FrameworkName()
             })
             .UniqueForRuntimeAndVersion();
     }
+#if NET6_0_OR_GREATER || NETFRAMEWORK
 
     [Theory]
     [InlineData(true, false)]
@@ -622,4 +623,5 @@ public Task HashParametersFluent(bool a, bool b) =>
         Verify("ContentHashParametersFluent")
             .UseHashedParameters(a, b)
             .HashParameters();
+#endif
 }
diff --git a/src/Verify/Naming/FileNameBuilder.cs b/src/Verify/Naming/FileNameBuilder.cs
@@ -1,4 +1,6 @@
-using System.IO.Hashing;
+#if NET6_0_OR_GREATER || NETFRAMEWORK
+using System.IO.Hashing;
+#endif
 
 static class FileNameBuilder
 {
@@ -38,14 +40,17 @@ public static string GetParameterText(IReadOnlyList<string>? methodParameters, V
         builder.Length -= 1;
         var parameterText = builder.ToString();
 
+#if NET6_0_OR_GREATER || NETFRAMEWORK
         if (settings.hashParameters)
         {
             var hashed = HashString(parameterText);
             return $"_{hashed}";
         }
+#endif
         return parameterText;
     }
 
+#if NET6_0_OR_GREATER || NETFRAMEWORK
     static string HashString(string value)
     {
         var data = XxHash64.Hash(Encoding.UTF8.GetBytes(value));
@@ -59,4 +64,5 @@ static string HashString(string value)
 
         return builder.ToString();
     }
+#endif
 }
diff --git a/src/Verify/Naming/ParameterSettings.cs b/src/Verify/Naming/ParameterSettings.cs
@@ -52,6 +52,7 @@ public void IgnoreParametersForVerified(params object?[] parameters)
         ignoreParametersForVerified = true;
     }
 
+#if NET6_0_OR_GREATER || NETFRAMEWORK
     internal bool hashParameters;
 
     /// <summary>
@@ -75,4 +76,5 @@ public void UseHashedParameters(params object?[] parameters)
         UseParameters(parameters);
         HashParameters();
     }
+#endif
 }
diff --git a/src/Verify/SettingsTask.cs b/src/Verify/SettingsTask.cs
@@ -246,6 +246,7 @@ public SettingsTask UniqueForRuntimeAndVersion()
         return this;
     }
 
+#if NET6_0_OR_GREATER || NETFRAMEWORK
     /// <summary>
     /// Provide parameters to hash together and pass to <see cref="UseTextForParameters"/>.
     /// Used to get a deterministic file name while avoiding long paths.
@@ -267,6 +268,8 @@ public SettingsTask HashParameters()
         return this;
     }
 
+#endif
+
     /// <summary>
     /// Use the current processor architecture (x86/x64/arm/arm64) to make the test results unique.
     /// Used when a test produces different results based on processor architecture.

diff --git a/src/Verify/Verify.csproj b/src/Verify/Verify.csproj
@@ -10,7 +10,7 @@
   <ItemGroup>
     <PackageReference Include="Polyfill" Version="1.23.0" PrivateAssets="all" />
     <PackageReference Include="System.IO.Compression" Version="4.3.0" Condition="$(TargetFrameworkIdentifier) == '.NETFramework'" />
-    <PackageReference Include="System.IO.Hashing" Version="7.0.0" />
+    <PackageReference Include="System.IO.Hashing" Version="7.0.0" Condition="$(TargetFrameworkIdentifier) == '.NETFramework' or $(TargetFramework) == 'net6.0' or $(TargetFramework) == 'net7.0' or $(TargetFramework) == 'net8.0'"/>
     <PackageReference Include="System.Memory" Version="4.5.5" Condition="$(TargetFrameworkIdentifier) == '.NETStandard' or $(TargetFrameworkIdentifier) == '.NETFramework' or $(TargetFramework.StartsWith('netcoreapp2'))" />
     <Using Include="System.ReadOnlySpan&lt;System.Char&gt;" Alias="CharSpan" />
     <Using Include="Argon" />

diff --git a/src/Verify/VerifySettings.cs b/src/Verify/VerifySettings.cs
@@ -25,7 +25,11 @@ public VerifySettings(VerifySettings? settings)
         streamComparer = settings.streamComparer;
         parameters = settings.parameters;
         ignoreParametersForVerified = settings.ignoreParametersForVerified;
+
+#if NET6_0_OR_GREATER || NETFRAMEWORK
         hashParameters = settings.hashParameters;
+#endif
+
         parametersText = settings.parametersText;
         fileName = settings.fileName;
         UniquePrefixDisabled = settings.UniquePrefixDisabled;