Migrate to ESLint 9, new TypeScript ESLint, and more

eslint.config.js

@@ -0,0 +1,21 @@
+// @ts-check
+
+// @ts-ignore Needed due to moduleResolution Node vs Bundler
+import { tanstackConfig } from "@tanstack/config/eslint";
+
+export default [
+	...tanstackConfig,
+	{
+		name: "tanstack/temp",
+		rules: {
+			"@typescript-eslint/array-type": "off",
+			"@typescript-eslint/method-signature-style": "off",
+			"@typescript-eslint/naming-convention": "off",
+			"@typescript-eslint/no-unnecessary-type-assertion": "off",
+			"@typescript-eslint/no-unsafe-function-type": "off",
+			"@typescript-eslint/require-await": "off",
+			"no-async-promise-executor": "off",
+			"no-empty": "off",
+		},
+	},
+];

fixtures/sample/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

fixtures/sample/loader.ts

@@ -1,7 +1,7 @@
-import path from "path";
-import { Sample } from "./types";
+import path from "node:path";
 import { fileURLToPath } from "node:url";
 import * as fs from "node:fs";
+import type { Sample } from "./types";
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);

fixtures/sample/package.json

@@ -4,10 +4,15 @@
 	"version": "1.0.0",
 	"description": "",
 	"main": "index.js",
+	"type": "module",
 	"author": {
 		"name": "akfish",
 		"email": "[email protected]"
 	},
+	"scripts": {
+		"build": "tsc --noEmit",
+		"test:eslint": "eslint ./loader.ts ./server.ts ./types.ts"
+	},
 	"license": "MIT",
 	"devDependencies": {
 		"@types/finalhandler": "^1.1.1",

fixtures/sample/server.ts

@@ -1,5 +1,5 @@
-import * as path from "path";
-import * as http from "http";
+import * as path from "node:path";
+import * as http from "node:http";
 import finalhandler from "finalhandler";
 import serveStatic from "serve-static";
 

fixtures/sample/types.ts

@@ -1,4 +1,4 @@
-import { Palette } from "@vibrant/color";
+import type { Palette } from "@vibrant/color";
 
 export interface Sample {
 	name: string;

nx.json

@@ -10,6 +10,10 @@
 			"cache": true,
 			"dependsOn": ["^build"],
 			"outputs": ["{projectRoot}/dist"]
+		},
+		"test:eslint": {
+			"cache": true,
+			"dependsOn": ["^build"]
 		}
 	}
 }

package.json

@@ -2,27 +2,25 @@
 	"name": "node-vibrant-monorepo",
 	"private": true,
 	"packageManager": "[email protected]",
+	"type": "module",
 	"scripts": {
 		"compile:tsc": "tsc",
 		"build": "lerna run build",
-		"lint": "run-p -c lint:*",
-		"lint:packages": "eslint ./packages",
-		"lint:fixtures": "eslint ./fixtures",
 		"prettier": "prettier --ignore-unknown .",
 		"prettier:write": "pnpm run prettier --write",
 		"test": "run-p -c test:*",
 		"test:sherif": "sherif",
 		"test:lib": "lerna run test:lib",
+		"test:eslint": "lerna run test:eslint",
 		"test:format": "pnpm run prettier --check",
 		"test:knip": "knip",
 		"prepare": "husky install && playwright install chromium"
 	},
 	"devDependencies": {
+		"@tanstack/config": "^0.14.2",
 		"@types/node": "^18.15.3",
 		"@types/table": "^4.0.5",
-		"@typescript-eslint/eslint-plugin": "^5.6.0",
-		"@typescript-eslint/parser": "^5.6.0",
-		"eslint": "^8.6.0",
+		"eslint": "^9.17.0",
 		"husky": "^7.0.4",
 		"knip": "^5.41.0",
 		"lerna": "^8.1.9",

packages/node-vibrant/__tests__/common/helper.ts

@@ -1,15 +1,13 @@
 import { expect } from "vitest";
-import { VibrantStatic } from "@vibrant/core";
-import { Builder } from "@vibrant/core";
-import type { Palette, Swatch } from "@vibrant/color";
 import * as util from "@vibrant/color";
+import { getBorderCharacters, table } from "table";
+import type { Builder, VibrantStatic } from "@vibrant/core";
+import type { Palette, Swatch } from "@vibrant/color";
 import type {
-	TestSample,
 	SamplePathKey,
+	TestSample,
 } from "../../../../fixtures/sample/loader";
 
-import { table, getBorderCharacters } from "table";
-
 const TABLE_OPTS = {
 	border: getBorderCharacters("void"),
 };

packages/node-vibrant/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/node-vibrant/package.json

@@ -54,9 +54,6 @@
 		"dist",
 		"src"
 	],
-	"directories": {
-		"example": "examples"
-	},
 	"dependencies": {
 		"@types/node": "^18.15.3",
 		"@vibrant/core": "^4.0.0-alpha.3",
@@ -77,7 +74,8 @@
 	"scripts": {
 		"build": "vite build",
 		"test:lib": "vitest run",
-		"test:lib:watch": "vitest watch"
+		"test:lib:watch": "vitest watch",
+		"test:eslint": "eslint ./src ./__tests__"
 	},
 	"bugs": {
 		"url": "https://github.com/akfish/node-vibrant/issues"

packages/vibrant-color/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-color/package.json

@@ -3,7 +3,8 @@
 	"version": "4.0.0-alpha.3",
 	"description": "Color utilities for vibrant",
 	"scripts": {
-		"build": "vite build"
+		"build": "vite build",
+		"test:eslint": "eslint ./src"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-color/src/converter.ts

@@ -1,4 +1,4 @@
-import { Vec3 } from "./";
+import type { Vec3 } from "./";
 
 export const DELTAE94_DIFF_STATUS = {
 	NA: 0,

packages/vibrant-color/src/index.ts

@@ -1,5 +1,6 @@
+import { rgbToHex, rgbToHsl } from "./converter";
+
 export * from "./converter";
-import { rgbToHsl, rgbToHex } from "./converter";
 
 export interface Filter {
 	(red: number, green: number, blue: number, alpha: number): boolean;

packages/vibrant-core/__tests__/builder.spec.ts

@@ -1,4 +1,4 @@
-import { expect, it, describe } from "vitest";
+import { describe, expect, it } from "vitest";
 
 import { Builder } from "../src/builder";
 

packages/vibrant-core/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-core/package.json

@@ -5,7 +5,8 @@
 	"scripts": {
 		"test:lib": "vitest run",
 		"test:lib:watch": "vitest watch",
-		"build": "vite build"
+		"build": "vite build",
+		"test:eslint": "eslint ./src ./__tests__"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-core/src/options.ts

@@ -1,9 +1,11 @@
-import { Palette, Swatch, Filter } from "@vibrant/color";
-import { Image, ImageClass, ImageSource, ImageOptions } from "@vibrant/image";
-import { Quantizer, QuantizerOptions } from "@vibrant/quantizer";
+import { Filter, Palette, Swatch } from "@vibrant/color";
+import { Image, ImageSource } from "@vibrant/image";
+import { Quantizer } from "@vibrant/quantizer";
 import { Generator } from "@vibrant/generator";
-import { StageOptions, ProcessOptions } from "./pipeline";
 import { assignDeep } from "./utils";
+import type { ProcessOptions, StageOptions } from "./pipeline";
+import type { QuantizerOptions } from "@vibrant/quantizer";
+import type { ImageClass, ImageOptions } from "@vibrant/image";
 
 export interface Options extends ImageOptions, QuantizerOptions {
 	useWorker: boolean;

packages/vibrant-core/src/pipeline/index.ts

@@ -1,7 +1,8 @@
-import { ImageData, applyFilters } from "@vibrant/image";
-import { Quantizer } from "@vibrant/quantizer";
-import { Generator } from "@vibrant/generator";
-import { Palette, Swatch, Filter } from "@vibrant/color";
+import { applyFilters } from "@vibrant/image";
+import type { ImageData } from "@vibrant/image";
+import type { Quantizer } from "@vibrant/quantizer";
+import type { Generator } from "@vibrant/generator";
+import type { Filter, Palette, Swatch } from "@vibrant/color";
 
 export class Stage<T> {
 	private _map: { [name: string]: T } = {};

packages/vibrant-core/src/pipeline/worker/host.ts

@@ -1,5 +1,5 @@
 import { runInWorker } from "@vibrant/worker";
-import { Pipeline } from "../index";
+import type { Pipeline } from "../index";
 
 export function runPipelineInWorker(self: Window, pipeline: Pipeline) {
 	runInWorker(self, (imageData, opts) => pipeline.process(imageData, opts));

packages/vibrant-core/tsconfig.json

@@ -1,4 +1,4 @@
 {
 	"extends": "../../tsconfig.json",
-	"include": ["src", "vite.config.ts"]
+	"include": ["__tests__", "src", "vite.config.ts"]
 }

packages/vibrant-generator-default/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-generator-default/package.json

@@ -3,7 +3,8 @@
 	"version": "4.0.0-alpha.3",
 	"description": "Default generator that generates the original vibrant palette",
 	"scripts": {
-		"build": "vite build"
+		"build": "vite build",
+		"test:eslint": "eslint ./src"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-generator-default/src/index.ts

@@ -1,6 +1,7 @@
-import { Swatch, Palette } from "@vibrant/color";
-import { Generator } from "@vibrant/generator";
-import { hslToRgb } from "@vibrant/color";
+/* eslint-disable prefer-const, @typescript-eslint/no-unnecessary-condition */
+import { Swatch, hslToRgb } from "@vibrant/color";
+import type { Generator } from "@vibrant/generator";
+import type { Palette } from "@vibrant/color";
 
 interface DefaultGeneratorOptions {
 	targetDarkLuma: number;

packages/vibrant-generator/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-generator/package.json

@@ -3,7 +3,8 @@
 	"version": "4.0.0-alpha.3",
 	"description": "Helpers and typings for writing a vibrant generator",
 	"scripts": {
-		"build": "vite build"
+		"build": "vite build",
+		"test:eslint": "eslint ./src"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-generator/src/index.ts

@@ -1,6 +1,6 @@
-import { Palette, Swatch } from "@vibrant/color";
-import { Resolvable } from "@vibrant/types";
+import type { Palette, Swatch } from "@vibrant/color";
+import type { Resolvable } from "@vibrant/types";
 
 export interface Generator {
-	(swatches: Swatch[], opts?: Object): Resolvable<Palette>;
+	(swatches: Swatch[], opts?: object): Resolvable<Palette>;
 }

packages/vibrant-image-browser/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-image-browser/package.json

@@ -5,7 +5,8 @@
 	"scripts": {
 		"build": "vite build",
 		"test:lib": "vitest run",
-		"test:lib:watch": "vitest watch"
+		"test:lib:watch": "vitest watch",
+		"test:eslint": "eslint ./src ./__tests__"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-image-browser/src/index.ts

@@ -1,9 +1,7 @@
-import {
-	ImageOptions,
-	ImageData as VibrantImageData,
+import { ImageBase, ImageCallback, ImageOptions } from "@vibrant/image";
+import type {
 	ImageSource,
-	ImageCallback,
-	ImageBase,
+	ImageData as VibrantImageData,
 } from "@vibrant/image";
 
 function isRelativeUrl(url: string): boolean {

packages/vibrant-image-node/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];

packages/vibrant-image-node/package.json

@@ -3,7 +3,8 @@
 	"version": "4.0.0-alpha.3",
 	"description": "Node.js vibrant ImageClass implementation",
 	"scripts": {
-		"build": "vite build"
+		"build": "vite build",
+		"test:eslint": "eslint ./src"
 	},
 	"type": "module",
 	"types": "dist/esm/index.d.ts",

packages/vibrant-image-node/src/index.ts

@@ -1,7 +1,8 @@
-import { ImageBase, ImageData, ImageSource } from "@vibrant/image";
+import { ImageBase } from "@vibrant/image";
 import configure from "@jimp/custom";
 import types from "@jimp/types";
 import resize from "@jimp/plugin-resize";
+import type { ImageData, ImageSource } from "@vibrant/image";
 
 const Jimp = configure({
 	types: [types],

packages/vibrant-image/eslint.config.js

@@ -0,0 +1,5 @@
+// @ts-check
+
+import rootConfig from "../../eslint.config.js";
+
+export default [...rootConfig];