Fix/vicms 658 bepp and article urls generation #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulandrieux
force-pushed
the
fix/VICMS-658-bepp-and-article-urls-generation
branch
from
0e6fb88 to
3b8ba33
Compare
…tern into BusinessTemplate
…les from basics BusinessEntities
…which View you are caching
… not cache updating anymore cf ViewReferenceSubscriber
…t in cache so we fetch DB simplify service declaration
…ation and update the view cache with new urls
…_manager depedency
paulandrieux
force-pushed
the
fix/VICMS-658-bepp-and-article-urls-generation
branch
from
7d69c43 to
076019d
Compare
…e it to him to do database operations. This is needed because the QH is called by the ViewReferenceSubscriber that have it's own EM
…tuals because its Articles
…oreach loop that had for consequence to infinitely re-initialize the foreach
paulandrieux
force-pushed
the
fix/VICMS-658-bepp-and-article-urls-generation
branch
from
076019d to
d489354
Compare
… creation, not only WebViewInterface
paulandrieux
force-pushed
the
fix/VICMS-658-bepp-and-article-urls-generation
branch
from
e2abd38 to
82ac755
Compare
paulandrieux
added a commit
to paulandrieux/victoire
that referenced
this pull request
Sep 16, 2015
…and-article-urls-generation * fork/fix/VICMS-658-bepp-and-article-urls-generation: (54 commits) If we try to find a page in database, check page validity too fix phpdoc Entity manager is required If viewReference is not found, throw a more verbose exception fix some behat tests better error message + rename variable create the ViewReferenceProvider to find referencable views given a view move getAllViewsReference in the ViewCacheHelper compute view cache when a View is persisted to handle BusinessPattern creation, not only WebViewInterface fix behat test build url on load of a WebViewInterface do not compute viewReference for Template clean buildReference second parameter support "additionnalQueryPart" in ArticleTemplate $viewsReferences is given by reference and I re-allocated it in the foreach loop that had for consequence to infinitely re-initialize the foreach add the ArticleTemplateReferenceBuilder. It does not generate any virtuals because its Articles use entity metadatas to build entity namespace instead of simple get_class do not pass $entity to viewReferenceBuilders anymore remove url in test fixtures change BusinessTemplate show url in behat tests ...
paulandrieux
added a commit
to paulandrieux/victoire
that referenced
this pull request
Sep 16, 2015
…and-article-urls-generation * fork/fix/VICMS-658-bepp-and-article-urls-generation: (54 commits) If we try to find a page in database, check page validity too fix phpdoc Entity manager is required If viewReference is not found, throw a more verbose exception fix some behat tests better error message + rename variable create the ViewReferenceProvider to find referencable views given a view move getAllViewsReference in the ViewCacheHelper compute view cache when a View is persisted to handle BusinessPattern creation, not only WebViewInterface fix behat test build url on load of a WebViewInterface do not compute viewReference for Template clean buildReference second parameter support "additionnalQueryPart" in ArticleTemplate $viewsReferences is given by reference and I re-allocated it in the foreach loop that had for consequence to infinitely re-initialize the foreach add the ArticleTemplateReferenceBuilder. It does not generate any virtuals because its Articles use entity metadatas to build entity namespace instead of simple get_class do not pass $entity to viewReferenceBuilders anymore remove url in test fixtures change BusinessTemplate show url in behat tests ...
paulandrieux
added a commit
to paulandrieux/victoire
that referenced
this pull request
Sep 16, 2015
…and-article-urls-generation * fork/fix/VICMS-658-bepp-and-article-urls-generation: (54 commits) If we try to find a page in database, check page validity too fix phpdoc Entity manager is required If viewReference is not found, throw a more verbose exception fix some behat tests better error message + rename variable create the ViewReferenceProvider to find referencable views given a view move getAllViewsReference in the ViewCacheHelper compute view cache when a View is persisted to handle BusinessPattern creation, not only WebViewInterface fix behat test build url on load of a WebViewInterface do not compute viewReference for Template clean buildReference second parameter support "additionnalQueryPart" in ArticleTemplate $viewsReferences is given by reference and I re-allocated it in the foreach loop that had for consequence to infinitely re-initialize the foreach add the ArticleTemplateReferenceBuilder. It does not generate any virtuals because its Articles use entity metadatas to build entity namespace instead of simple get_class do not pass $entity to viewReferenceBuilders anymore remove url in test fixtures change BusinessTemplate show url in behat tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.