Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WidgetMap #338

Merged
merged 124 commits into from
Feb 17, 2016
Merged

Refactor WidgetMap #338

merged 124 commits into from
Feb 17, 2016

Conversation

lenybernard
Copy link
Contributor

Yesterday WidgetMaps were serialized systems.
It was first very usefull but it made the drag and drop and the widget override (especially for templates and BusinessTemplates) really painfull 😭

Today, @paulandrieux is introducing the new WidgetMap system based on Doctrine Entities.

@paulandrieux
move WidgetMap in WidgetMapBundle and declare it as an entity
550bb9d
@paulandrieux
a view is no longer related to widgets but to WidgetMaps
213027a
@paulandrieux
clean widget entity and use widget entity instead of model
c32fdc2
@paulandrieux
phpdoc
13cbbcf
@paulandrieux
enable web debug toolbar in test env
08f1ca7
@paulandrieux
a widget is not related to a view anymore, so use custom method to fi…
a31666b 
…nd a widget in a view
@paulandrieux
refactor widgetMapBuilder
f6988dd
@paulandrieux
kick unused widgetmapPositionBuilder
7b7139d
@paulandrieux
kick unused transformer and helper
e7b9c33
@paulandrieux
use new build method
e85840a
@paulandrieux
refactor form controller/builder to respect new widgetmap strategy
9397ff1
@paulandrieux
clarify widgetMapManager: now it can insert/move/delete widgetMap
6eae231
@paulandrieux
use the new WidgetMapManager
3aa098a
@paulandrieux
render widget actions the new way
98902b8
@paulandrieux
adapt javascript
6f4894f
@paulandrieux
add some tests
9a966c0
@paulandrieux
use getChildren to fetch children related to replaced widgetMap
8a2f207
@paulandrieux
write some unit tests
d969ff2
@paulandrieux
some PHPCS
0bf6cb2
@paulandrieux
handle wen widget buttons the angular way
dced0e3
@paulandrieux
do not generate new widget buttons, let angular do it
b4f3abd
@paulandrieux
compute available positions for given view
29cfd57
@paulandrieux
use widget available positions when render a page and when update a w…
dc5a2f4 
…idget position to regenerate new widget buttons
@paulandrieux
set substitute when set a parent to a widget
a025818
@paulandrieux
when I am not logged with role victoire, do not generate the angulat …
4c018c1 
…widget element
@paulandrieux
update tests
809d62b
@paulandrieux
the baseResolver should use the widget model to not break widgets com…
0498a8a 
…ptability
@paulandrieux
add a js translation bundle to handle angular new content select crea…
8603946 
…tion
@paulandrieux
do not store angular application initialization in a variable cause i…
2b0e2f2 
…t prevent adding modules later. Prefer the good practice fetching the application througth angular.module('ngApp')
@paulandrieux
tell angular to generate new content select and add assets for transl…
e86a4db 
…ation component
paulandrieux and others added 21 commits February 17, 2016 18:55
@paulandrieux
Respect Action convention
4c584ae
@paulandrieux
compute only for after and before positions (avoid error on "id" prop…
9622db8 
…erty)
@paulandrieux
init widgetmaps to an empty array to be able to iterate over it when …
2224e54 
…it's empty
@paulandrieux
do not getch widgetmaps if we are not in a victoire page
36a7e3e
@paulandrieux
check if widgetmaps is not null before iterate over it
e8e7bde
@paulandrieux
remove widgetmaps when a page is deleted and set null when a widget i…
83a6fd1 
…s deleted
@paulandrieux
show "Victoire !" alert when a widget is edited/created
b4282de
@paulandrieux
move cookie_domain config in domain env config
65a3198
@paulandrieux
wait for new widget button when I switch in layout mode
879974c
@paulandrieux
remove obsolete widget->getView()
3be1511
@paulandrieux
give locale as query parameter
c782a21
@paulandrieux
fix inarray test
dd60b24
@paulandrieux
set WidgetMap view if it has none at the moment to avoid to erase vie…
43a3cc5 
…ws when a widgetmap is associated to a virtual page
@paulandrieux
update xpath with new dom
8a2721b
@paulandrieux
update behat widget move step to be consistant with widgetmap tree
e76762e
@paulandrieux
add some waits
148d9ac
@paulandrieux
add bazinga dump
3ddd6ba
@paulandrieux
disable debug env for test env
f90da6d
@paulandrieux
require BaseEntityProxy instead of generated EntityProxy
4755f09
@StyleCIBot
Applied fixes from StyleCI
598d5ba
Merge pull request #7 from lenybernard/analysis-XajJNk
ef749a4 
Applied fixes from StyleCI
@lenybernard lenybernard added this to the WidgetMap milestone Feb 17, 2016
@lenybernard lenybernard changed the title Feature/refactor dnd Refactor WidgetMap Feb 17, 2016
lenybernard pushed a commit that referenced this pull request Feb 17, 2016
Merge pull request #338 from lenybernard/feature/refactor-dnd
e2858e9 
Refactor WidgetMap
@lenybernard lenybernard merged commit e2858e9 into Victoire:master Feb 17, 2016
@lenybernard lenybernard deleted the feature/refactor-dnd branch February 17, 2016 21:10
@paulandrieux
Copy link
Member

🌈 YAY ! 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
~refactor
Projects
None yet
Milestone
WidgetMap
Development

Successfully merging this pull request may close these issues.
3 participants
@lenybernard @paulandrieux @scrutinizer-auto-fixer