Skip to content

Commit

Permalink
operator: fixes bug with incorrectly added liveness and readiness pro…
Browse files Browse the repository at this point in the history
…bes for config-reloader container
  • Loading branch information
f41gh7 committed Apr 18, 2024
1 parent 781dbba commit 3d7bcba
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion controllers/factory/build/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ var (
// AddsPortProbesToConfigReloaderContainer conditionally adds readiness and liveness probes to the custom config-reloader image
// exposes reloader-http port for container
func AddsPortProbesToConfigReloaderContainer(crContainer *v1.Container, c *config.BaseOperatorConf) {
if c.UseCustomConfigReloader && c.CustomConfigReloaderImageVersion().LessThan(minimalHealthProbeSupportedVersion) {
if !c.UseCustomConfigReloader || c.CustomConfigReloaderImageVersion().LessThan(minimalHealthProbeSupportedVersion) {
return
}
crContainer.Ports = append(crContainer.Ports, v1.ContainerPort{
Expand Down
7 changes: 6 additions & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@ aliases:

## Next release

<a name="v0.43.1"></a>
## [v0.43.1](https://github.com/VictoriaMetrics/operator/releases/tag/v0.43.1) - 18 Apr 2024

- [operator](./README.md): properly add `liveness` and `readiness` probes to `config-reloader`, if `VM_USECUSTOMCONFIGRELOADER=false`.

<a name="v0.43.0"></a>
## [v0.43.](https://github.com/VictoriaMetrics/operator/releases/tag/v0.43.0) - 18 Apr 2024
## [v0.43.0](https://github.com/VictoriaMetrics/operator/releases/tag/v0.43.0) - 18 Apr 2024

**Update note: [vmcluster](./api.md#vmcluster): remove fields `VMClusterSpec.VMInsert.Name`, `VMClusterSpec.VMStorage.Name`, `VMClusterSpec.VMSelect.Name`, they're marked as deprecated since v0.21.0. See [this pull request](https://github.com/VictoriaMetrics/operator/pull/907).**
**Update note: PodSecurityPolicy supports was deleted. Operator no long creates PSP related objects since it's no longer supported by Kubernetes actual versions. See this [doc](https://kubernetes.io/blog/2021/04/08/kubernetes-1-21-release-announcement/#podsecuritypolicy-deprecation) for details.**
Expand Down

0 comments on commit 3d7bcba

Please sign in to comment.