You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, operator generates VMServiceScrape config for each port defined at Service. It produces the following configuration for the vmbackupmanager:
It makes produces metrics with the same job name, but different addresses and container names. And it makes metrics hard to use with grafana dashboards that relies only at job labels to distinguish components.
I propose the following changes:
add port suffix for non default (aka http) ports with relabelConfigs.
by default generate endpoints only for http and vmbackupamanger ports. Currently it will be generate for the any ports defined at Service.
The text was updated successfully, but these errors were encountered:
Previously, operator doesn't filter ports from Service provided to the VMServiceScrape builder.
It may lead to the unwanted VMServiceScrape endpoints.
E.g. user defined additional port with serviceScrape and set `useAsDefault: true`. Operator may use
this port as a target for the VMServiceScrape. Which is unwanted behaviour.
Also, generated VMServiceScrape uses a same job name for the multiple ports. It makes metrics hard to use
with official VictoriaMetrics dashboards.
This commit adds a suffix with portname to the generated endpoints.
Related issue:
#1216
Signed-off-by: f41gh7 <[email protected]>
Currently, operator generates
VMServiceScrape
config for each port defined atService
. It produces the following configuration for the vmbackupmanager:It makes produces metrics with the same job name, but different addresses and container names. And it makes metrics hard to use with grafana dashboards that relies only at
job
labels to distinguish components.I propose the following changes:
port
suffix for non default (akahttp
) ports with relabelConfigs.http
andvmbackupamanger
ports. Currently it will be generate for the any ports defined atService
.The text was updated successfully, but these errors were encountered: