Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vmbackupmanager suffix to the job label for auto-generated vmservicescrape #1216

Closed
f41gh7 opened this issue Jan 14, 2025 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@f41gh7
Copy link
Collaborator

f41gh7 commented Jan 14, 2025

Currently, operator generates VMServiceScrape config for each port defined at Service. It produces the following configuration for the vmbackupmanager:

  - attach_metadata: {}
    path: /metrics
    port: http
  - attach_metadata: {}
    path: /metrics
    port: vmbackupmanager

It makes produces metrics with the same job name, but different addresses and container names. And it makes metrics hard to use with grafana dashboards that relies only at job labels to distinguish components.

I propose the following changes:

  • add port suffix for non default (aka http) ports with relabelConfigs.
  • by default generate endpoints only for http and vmbackupamanger ports. Currently it will be generate for the any ports defined at Service.
@f41gh7 f41gh7 added the enhancement New feature or request label Jan 14, 2025
f41gh7 added a commit that referenced this issue Jan 21, 2025
Previously, operator doesn't filter ports from Service provided to the VMServiceScrape builder.
It may lead to the unwanted VMServiceScrape endpoints.

 E.g. user defined additional port with serviceScrape and set `useAsDefault: true`. Operator may use
this port as a target for the VMServiceScrape. Which is unwanted behaviour.

 Also, generated VMServiceScrape uses a same job name for the multiple ports. It makes metrics hard to use
with official VictoriaMetrics dashboards.

 This commit adds a suffix with portname to the generated endpoints.

Related issue:
#1216

Signed-off-by: f41gh7 <[email protected]>
@f41gh7 f41gh7 added the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 21, 2025
@f41gh7
Copy link
Collaborator Author

f41gh7 commented Jan 22, 2025

Feature was added at v0.52.0 release

@f41gh7 f41gh7 closed this as completed Jan 22, 2025
@f41gh7 f41gh7 removed the waiting for release The change was merged to upstream, but wasn't released yet. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant