Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/vmagent: support flush_on_shutdown for streamingaggregation configuration #860

Closed
rjrooke opened this issue Jan 29, 2024 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@rjrooke
Copy link

rjrooke commented Jan 29, 2024

It appears this configuration item may not be supported by the operator:

  # staleness_interval defines an interval after which the series state will be reset if no samples have been sent during it.
  # It means that:
  # - no data point will be written for a resulting time series if it didn't receive any updates during configured interval,
  # - if the series receives updates after the configured interval again, then the time series will be calculated from the initial state
  #   (it's like this series didn't exist until now).
  # Increase this parameter if it is expected for matched metrics to be delayed or collected with irregular intervals exceeding the `interval` value.
  # By default, is equal to x2 of the `interval` field.
  # The parameter is only relevant for outputs: total, increase and histogram_bucket.
  #
  # staleness_interval: 2m

https://docs.victoriametrics.com/stream-aggregation/#stream-aggregation-config

Error from server (BadRequest): error when replacing "webscale-vmb-feed.yaml": VMAgent in version "v1beta1" cannot be handled as a VMAgent: strict decoding error: unknown field "spec.remoteWrite[5].streamAggrConfig.rules[0].flush_on_shutdown"

@rjrooke
Copy link
Author

rjrooke commented Jan 29, 2024

unclear if this is even a valid option - comes right out of agent docs, but this occurs with updated config:

2024-01-29T19:09:49.847Z	fatal	VictoriaMetrics/app/vmagent/remotewrite/remotewrite.go:745	cannot initialize stream aggregators from -remoteWrite.streamAggr.config="/etc/vm/stream-aggr/RWS_5-CM-STREAM-AGGR-CONF": cannot initialize aggregators from "/etc/vm/stream-aggr/RWS_5-CM-STREAM-AGGR-CONF": cannot parse stream aggregation config: yaml: unmarshal errors:
  line 5: field flush_on_shutdown not found in type streamaggr.Config

@Haleygo
Copy link
Contributor

Haleygo commented Jan 30, 2024

Hello!
flush_on_shutdown is not released yet and will be included in the next release[v1.97.0].
And operator will add this field afterwards.

@Haleygo Haleygo added the enhancement New feature or request label Jan 30, 2024
@Haleygo Haleygo changed the title flush_on_shutdown for streamingaggregation configuration in operator api/vmagent: support flush_on_shutdown for streamingaggregation configuration Jan 30, 2024
f41gh7 added a commit that referenced this issue Mar 1, 2024
VictoriaMetrics components support it since v1.97.0 version
#860
@f41gh7
Copy link
Collaborator

f41gh7 commented Mar 6, 2024

Added to the v0.42.0 release

@f41gh7 f41gh7 closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants