Reconciliation Loop for Prometheus Converter

[mirondeldev]

Current behavior of the vmprometheusconverter rely on Prometheus CRD create and update events, e.g.:

operator/controllers/vmprometheusconverter_controller.go

Lines 86 to 88 in e261c37

	c.ruleInf.AddEventHandler(cache.ResourceEventHandlerFuncs{
	AddFunc: c.CreatePrometheusRule,
	UpdateFunc: c.UpdatePrometheusRule,

In some cases (like manual or circumstantial deletion of custom resources) it leads to "orphaned" Prometheus resources.

So, the problem is VictoriaMetrics Operator does not recreate converted VM-resources after ones being deleted

Steps to reproduce

• Create Prometheus resource, e.g. PodMonitor
  • Operator creates corresponding PodScraper resource
• Delete created PodScraper resource and keep original Prometheus PodMonitor
  • PodScraper resource will not be created until PodMonitor will be updated or recreated

Would you please consider implementing reconciliation loop for Prometheus resources in vmprometheusconverter?

[f41gh7]

Hello, it makes sense to me. And it'd be great to have an option to enable periodical reconciliation of prometheus watched objects.

[f41gh7]

Added new flag for period reconciliation at v0.42.2 release

It accepts duration format, -controller.prometheusCRD.resyncPeriod=10m.

By default, it's disabled.

[mirondeldev]

@f41gh7 thx, much appreciated