Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the controller runtime #878

Closed
cedericboersting opened this issue Feb 28, 2024 · 2 comments
Closed

Upgrade the controller runtime #878

cedericboersting opened this issue Feb 28, 2024 · 2 comments

Comments

@cedericboersting
Copy link

Since the update 0.15 of the controller runtime there is a breaking change in the admission.Validator for the webhooks.
The signature of this method added another return type.

https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/webhook/admission/validator.go

The new signature is:
ValidateCreate() (admission.Warnings, error)
@f41gh7
Copy link
Collaborator

f41gh7 commented Feb 28, 2024

related issue #859

f41gh7 added a commit that referenced this issue Mar 1, 2024
@f41gh7
operator: updates kubernetes libs to 1.27.11, update controller-runti…
f355008 
…me to 0.17.2

it must fix possible issue with breaking changes introduced at controller-runtime webhook package
but it breaks backward compatibility. So it's a breaking change and requires operator users to update lib as well
#859
#878
f41gh7 added a commit that referenced this issue Mar 1, 2024
@f41gh7
operator: updates kubernetes libs to 1.27.11, update controller-runti…
4232271 
…me to 0.17.2

it must fix possible issue with breaking changes introduced at controller-runtime webhook package
but it breaks backward compatibility. So it's a breaking change and requires operator users to update lib as well
#859
#878
@f41gh7
Copy link
Collaborator

f41gh7 commented Mar 6, 2024

upgraded at v0.42.0 release

@f41gh7 f41gh7 closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f41gh7 @cedericboersting