Added support for maxDiskUsagePerURL and forceVMProto in vmagent remoteWriteSpec #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandregagnonlewis
requested review from
f41gh7,
Haleygo and
AndrewChubatiuk
as code owners
config/base/kustomization.yaml
Outdated
| @@ -4,3 +4,9 @@ patches: | |||
| - path: manager_webhook_patch.yaml | |||
| target: | |||
| kind: Deployment | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
@leandregagnonlewis could you please reset changes in this file?
f41gh7
previously approved these changes
Oct 3, 2024
updated changelog
leandregagnonlewis
force-pushed
the
feature/more-vmagent-remotewrite-spec-options
branch
from
23be6f1 to
8c99c3a
Compare
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Added two fields to
VMAgentRemoteWriteSpec:forceVMProtomaxDiskUsageThis allows to easily configure different remote write destination without using the
extraArgs.When only some of the remote write destinations are set, the others are set to the default value of
"1073741824"which was the default value set inVMAgentRemoteWriteSettings.If
maxDiskUsageis set in bothVMAgentRemoteWriteSettingsandVMAgentRemoteWriteSpec, onlyVMAgentRemoteWriteSpecis used. IfextraArgsis also used,extraArgsstill takes precedence.For
forceVMProto, it is also overriden byextraArgsif the flag is set there.