Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale control improvements #983

Closed
wants to merge 0 commits into from
Closed

Scale control improvements #983

wants to merge 0 commits into from

Conversation

TomaszLakota
Copy link

  • allow using colon in scale input
  • allow numerator different than 1 as input

Viglino added a commit that referenced this pull request Aug 7, 2023
@Viglino
[UPD] Scale control improvements #983
c375b87
@Viglino
Copy link
Owner

Viglino commented Aug 7, 2023

The scale decoding is part of the ol_sphere_setMapScale function.
I've added your code at c375b87#diff-fa5ed22ae705521425e42951f88139b463ed3f155777dc39f2b80ead934b1813

@TomaszLakota
Copy link
Author

Cool, I'd also rename value to event in setScale(value), because that's what the param the function gets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomaszLakota @Viglino