Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bao toggle #152

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

jfg69
Copy link

@jfg69 jfg69 commented Mar 6, 2023

This is a first version without the tooltip (because tooltip component is not ready yet, i'm working on it)

I'd like that someone else test this component in storybook because I have some issues in storybook like I explaned in the Angular UI chat Room.

Issues :

  • The first toggle display in every examples in story doesen't work properly (toggle don't work)
  • In the hiddenLabel example the label is not hidden for the first toggle and the spacing is not OK (I saw a box-sizing that broke it)

I test the component in a test project an everything is rendered correctly.

Jean-francois Gamache added 3 commits February 20, 2023 16:28
@jfg69 jfg69 requested a review from a team as a code owner March 6, 2023 15:37
@OlivierAlbertini OlivierAlbertini requested a review from a team March 8, 2023 19:45
@OlivierAlbertini
Copy link
Member

Sorry, I don't have the bandwidth for now but I will take a look as soon as possible

Jean-francois Gamache and others added 5 commits March 27, 2023 10:54
Signed-off-by: Jean-Francois Gamache <[email protected]>
fix storybook

Signed-off-by: Jean-Francois Gamache <[email protected]>
Signed-off-by: Jean-Francois Gamache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants