This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Add static property to set the protocol used with the API URLs. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getProtocol and setProtocol static methods to USPSBase to allow changing the API protocol as needed. Signed-off-by: Tristan Hall <[email protected]>
|
@tristanhall if they deprecate the http protocol wouldn't it make sense to just use https and not have this as an option? we can tag this as a minor version. thoughts? |
|
@VinceG Yep, that makes sense. My intention was to provide an option to switch in case someone wasn't ready to adopt HTTPS, but simply switching over to https would make for a smaller code change. Thanks for the quick feedback! 😃 |
added 2 commits
March 13, 2021 14:56
This reverts commit 7b9bf94.
Signed-off-by: Tristan Hall <[email protected]>
VinceG
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getProtocol and setProtocol static methods to USPSBase to allow changing the API protocol as needed.
Fix for #59