Add CLR error message from ElasticSearch #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reveiw task created: https://virtocommerce.atlassian.net/browse/PT-9590 |
OlegoO
approved these changes
Nov 14, 2022
OlegoO
requested changes
Nov 14, 2022
src/VirtoCommerce.ElasticSearchModule.Data/ElasticSearchProvider.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearchModule.Data/ElasticSearchProvider.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.ElasticSearchModule.Data/ElasticSearchProvider.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
@OlegoO elastic/elasticsearch-net#1793 (comment) |
OlegoO
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there is no message if any CLR exception occurs during Indexation create/update.
UI:
However, perhaps better aproach would be enable .ThrowExceptions() options for Provider, but this need proper testsing.
References
elastic/elasticsearch-net#1793
QA-test:
Jira-link:
Artifact URL: https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.ElasticSearch_3.210.0-pr-46-172f.zip