-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala CLI prints errors from the previous compilation #2226
Labels
blocked upstream
Issues and changes blocked by something in an external project.
Bloop
Issues tied with Bloop integration.
bug
Something isn't working
Comments
Gedochao
added
the
requires scoping
Issue requires a spike to revalidate it and assign an up-to date scope for its requirements.
label
Apr 12, 2024
I checked again and it seems to still fail, but it only fails for Scala CLI if the current file returns to the previous compiling code. If it's changed in any way this doesn't show up. Also, I run using plain Bloop command and this didn't show up, so my guess is that we cache something inside Scala CLI itself |
tgodzik
removed
the
requires scoping
Issue requires a spike to revalidate it and assign an up-to date scope for its requirements.
label
Apr 15, 2024
Gedochao
added
blocked upstream
Issues and changes blocked by something in an external project.
Bloop
Issues tied with Bloop integration.
labels
Jun 26, 2024
tgodzik
added a commit
to tgodzik/bloop
that referenced
this issue
Sep 10, 2024
We need to report all problems if a BSP client just connected to the server and never compiled. `reportAllPreviousProblems` will be set to true in that case. However, if previously we had an error, which was reverted and got back to the state before the error, we will get a successfull noop compilation, which will not produce any problems. In this case we don't want to republish everything again, since diagnostics will contain the error which was reverted. Connected to VirtusLab/scala-cli#2226 where CLI always connected anew.
tgodzik
added a commit
to tgodzik/bloop
that referenced
this issue
Sep 11, 2024
We need to report all problems if a BSP client just connected to the server and never compiled. `reportAllPreviousProblems` will be set to true in that case. However, if previously we had an error, which was reverted and got back to the state before the error, we will get a successfull noop compilation, which will not produce any problems. In this case we don't want to republish everything again, since diagnostics will contain the error which was reverted. Connected to VirtusLab/scala-cli#2226 where CLI always connected anew.
bump @tgodzik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked upstream
Issues and changes blocked by something in an external project.
Bloop
Issues tied with Bloop integration.
bug
Something isn't working
Version(s)
1.0.1
Describe the bug
Scala CLI prints errors from the previous compilation
To Reproduce
It should not print the error at the end because the code is compiling fine.
The text was updated successfully, but these errors were encountered: