use 'thiserror' to define 'Error'

[danieleades]

actually doesn't add a great deal of value to such a simple error type, but leaving here for discussion

[VirxEC]

Does thiserror actually implement anything that wasn't before? I don't want to add an additional dependency for something so minor.

[danieleades]

Does thiserror actually implement anything that wasn't before? I don't want to add an additional dependency for something so minor.

no it doesn't add anything that wasn't there before. It's a compile-time only macro- it's entirely equivalent at runtime.

[VirxEC]

I don't see the point, then. I love thiserror and I've used it before, but I think it's unnecessary here. The reason why use std::error::Error; is the only import from std is that this crate can go no-std once Rust 1.81 becomes a little older and it can be changed to importing from core instead. All this crate does is a bit of math, seems like a shame that isn't not no-std (with an std feature.)

[danieleades]

No-std support possibly coming soon: dtolnay/thiserror#304