-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing French translations; COUNTRY=rbd #1306
base: master
Are you sure you want to change the base?
Conversation
Build succeeded and deployed at https://prism-1306.surge.sh |
@wadhwamatic this should help |
@ericboucher - I'm still not seeing some missing keys listed until after interacting with the app. Hoping we can find a way to show all missing keys when the app first loads. |
@wadhwamatic please list those somewhere so that we can keep track |
@ericboucher - it seems that until layer are accessed, they may not be evaluated for missing translation keys. In this case, the last few entries in the translation file didn't appear until after I accessed the relevant layers.
|
@wadhwamatic maybe it wasn't super clear but currently we have two processes for missing keys. The more powerful one is running when we run the test commands and runs for every country and every language in that country, then outputs a table of missing keys. The keys you mentioned above were in the json file I sent you the other day that I created using that system. It accesses json files directly The other one is the web console. It is more accurate but is linked directly to the translation mechanism and so only lists missing keys on render, when they are actually called on the frontend. The keys you mentioned should be listed in the test version. I can experiment with adding the missing keys from the tests directly to the list in dev mode to "merge" the two methods but it would be a bit more complicated. |
@wadhwamatic updated, I merged the two solutions so now the console missing items is pre-loaded with the missing keys from the layer definitions and legends |
Yeah, I didn't catch that. So, how do I run the test command version and access that output? |
You can simply run "yarn test". But I also just added that output to the frontend list of missing keys for convenience |
Thanks @ericboucher. I see that shared layers that are used were still getting flagged for missing translations. Can we add logic that only checks for shared layers that are implemented in the country instance's prism.json? |
@wadhwamatic I added a filter to only show the missing keys for layerIds that appear in prism.json |
Description
Add missing translations
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn start
REACT_APP_COUNTRY=cambodia yarn start
REACT_APP_COUNTRY=mozambique yarn start
Screenshot/video of feature: