Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests that failed in CI #1346

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Updating tests that failed in CI #1346

merged 6 commits into from
Sep 25, 2024

Conversation

gislawill
Copy link
Collaborator

@gislawill gislawill commented Sep 19, 2024

Description

These are failing in CI due to an error from the OWS. I think we'll need @valpesendorfer help figuring out why they're failing in CI but not when the test is run locally. Skipping until then.

The tests are failing due to a 500 from https://api.earthobservation.vam.wfp.org/ows/?service=WCS&request=GetCoverage&version=2.0.0&coverageId=wp_pop_cicunadj&subset=Long(95.71,96.68)&subset=Lat(19.42,20.33)

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented Sep 19, 2024

Build succeeded and deployed at https://prism-1346.surge.sh
(hash 6bc9e40 deployed at 2024-09-25T08:38:17)

@ericboucher
Copy link
Collaborator

@gislawill I think it would be better to update this test instead to not use a WCS request

@ericboucher ericboucher changed the title Skipping test that fails in CI Updating tests that failed in CI Sep 20, 2024
@ericboucher
Copy link
Collaborator

@gislawill let me know what you think of the changes. This should be a bit more stable and avoids skipping tests.

@gislawill
Copy link
Collaborator Author

Thanks Eric. This update looks good to me. One thought, could we use the server in our test suite (the locally running test server) rather than the production server? Would rather rely on a the functionality already in our test suite than introducing a production dependency.

Also, I'm currently in the middle of a move but can test that suggestion out later this week

@ericboucher ericboucher merged commit 0bce0ee into master Sep 25, 2024
6 checks passed
@ericboucher ericboucher deleted the fix/failing-test branch September 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants