Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeline "new year" bug #1412

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Fix timeline "new year" bug #1412

merged 8 commits into from
Jan 16, 2025

Conversation

ericboucher
Copy link
Collaborator

@ericboucher ericboucher commented Jan 15, 2025

Description

This fixes #1411.

I made two small changes to fix the issue:

  • add a buffer of one so that we can use the increment to switch between years
  • revert to using the full availableDates array for the final update function

Unrelated, this PR also fixes a small bug in the Python API CI by fixing the Python version.

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented Jan 15, 2025

Build succeeded and deployed at https://prism-1412.surge.sh
(hash 2a49cf2 deployed at 2025-01-15T22:45:11)

@ericboucher ericboucher changed the title [TEST] - New year date bug Fix timeline "new year" bug Jan 15, 2025
@ericboucher ericboucher marked this pull request as ready for review January 15, 2025 21:08
@wadhwamatic
Copy link
Member

looks good from my side @ericboucher, thanks. Did you intend to keep the console logs?

@gislawill
Copy link
Collaborator

Just ran through the paces with seasonal CDI paired with various wms layers — all the logic worked well. Nice work @ericboucher

@ericboucher ericboucher merged commit 3ad6e08 into master Jan 16, 2025
6 checks passed
@ericboucher ericboucher deleted the date-bug-test branch January 16, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: unable to navigate back in timeline
3 participants