Replace top-level event-report windows in source with trigger specs #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the specs are still based on the default trigger data cardinality, but that the other algorithms are abstracted over specs instead of themselves assuming the default.
apasel422
force-pushed
the
rem-top-level
branch
from
e20aac6 to
dcb46db
Compare
apasel422
requested review from
johnivdel
and removed request for
linnan-github
apasel422
added
the
flexible-event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the specs are still based on the default trigger data cardinality, but that the other algorithms are abstracted over specs instead of themselves assuming the default.
Preview | Diff