Allow trigger side filtering on aggregation keys #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested changes
Jan 24, 2024
apasel422
requested changes
Jan 26, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
reviewed
Jan 31, 2024
|
The change has been approved by the measurement review team. |
apasel422
requested changes
Feb 12, 2024
apasel422
reviewed
Feb 12, 2024
apasel422
approved these changes
Feb 12, 2024
linnan-github
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a list of dictionaries to be taken in for the
aggregatable_valuesfield in trigger registrations, where each dictionary contains a dictionary of aggregatable values as well as a pair of filters, allowing for filtering aggregation keys on the trigger side. This change is backwards compatible and maintains original behavior as well.Resolves #649.
Preview | Diff