Use more precise warning when public suffix is used as a destination #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linnan-github
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Actually if https://com is allowed by Chromium, should the header validator align?
apasel422
changed the title
Updated to instead provide a better warning, rather than an error. |
linnan-github
approved these changes
Dec 10, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 11, 2024
The subtle behavior here was uncovered while working on WICG/attribution-reporting-api#1477, and we should ensure that it is interoperable across implementations. Change-Id: I5208280498350744e6bc84064edd1d7c978d3fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088277 Reviewed-by: Nan Lin <[email protected]> Commit-Queue: Andrew Paseltiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1394874}
giladbarkan-github
pushed a commit
to giladbarkan-github/attribution-reporting-api
that referenced
this pull request
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, previously https://com would be reported as the warning "URL components other than site (https://null) will be ignored".