Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reverts verify v2 #5286

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: reverts verify v2 #5286

merged 1 commit into from
Aug 20, 2024

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Aug 20, 2024

Description

Reverting Verify v2 implementation due to a bug with the .es.js builds

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

reown-com/web-examples#677

Fixes/Resolves (Optional)

https://walletconnect.slack.com/archives/C03RVH94K5K/p1724004457285959

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🙏

@ganchoradkov ganchoradkov merged commit bc28c5c into v2.0 Aug 20, 2024
13 checks passed
github-merge-queue bot referenced this pull request in valora-inc/wallet Aug 22, 2024
…^2.15.1 (#5817)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo)
| [`^2.15.0` ->
`^2.15.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.0/2.15.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.0/2.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.0/2.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.1)

[Compare
Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.15.0...2.15.1)

#### What's Changed

- chore: prep for `2.15.0` release by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5273](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5273)
- chore: reverts verify v2 by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5286](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5286)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.0...2.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants