New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reconnection loop #5315

Merged

ganchoradkov merged 1 commit into v2.0 from fix/reconnection-loop

Aug 29, 2024

Member

ganchoradkov commented Aug 28, 2024

Description

Fixing a bug where the relayer could go into reconnection loop when multiple disconnect events are received at the same time. It was observed that such issue appears on Safari with the native web socket

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

integration tests, dogfooding

Fixes/Resolves (Optional)

https://walletconnect.slack.com/archives/C04DB2EAHE3/p1724737009124569

Checklist

I have performed a self-review of my own code
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.


          fix: fixes bug where relayer could go into reconnection loop when mul…

dbbf7c2

…tiple disconnect events are emitted at the same time

ganchoradkov requested a review from Cali93

August 28, 2024 11:21

arein added the accepted label

ganchoradkov changed the title ~~fix: fixes bug where relayer could go into reconnection loop when mul…~~ fix: reconnection loop

Cali93 approved these changes

View reviewed changes

Contributor

Cali93 left a comment

Perfect, we should have a look into the whole code base and make sure we clear timeouts. Can you create a linear ticket and put mark it as tech debt ? 🙏

ganchoradkov merged commit 4c793bf into v2.0

13 checks passed

ganchoradkov deleted the fix/reconnection-loop branch

August 29, 2024 14:26

ganchoradkov mentioned this pull request

chore: prep for 2.15.2 release #5319

Merged

20 tasks

github-merge-queue bot referenced this pull request in valora-inc/wallet


          chore(deps): update dependency @walletconnect/react-native-compat to …

9da95fc

…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://togithub.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>

github-merge-queue bot referenced this pull request in valora-inc/wallet


          chore(deps): update dependency @walletconnect/react-native-compat to …

960f9b7

…^2.15.2 (#5871)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo)
| [`^2.15.1` ->
`^2.15.2`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.15.1/2.15.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.2`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.2)

[Compare
Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.15.1...2.15.2)

##### What's Changed

- chore: prep for 2.15.1 release by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5287](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5287)
- feat: events sdk by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5188](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5188)
- chore: sets `trace` level logging on canary by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5292](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5292)
- fix: Verify V3 by
[@&#8203;chris13524](https://togithub.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5285](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5285)
- Revert "chore: reverts verify v2" by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5288](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5288)
- fix(deps): update dependency elliptic to v6.5.7 \[security] by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5275](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5275)
- chore: doesn't init verify api in dev mode by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5309](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5309)
- fix: reconnection loop by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5315](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5315)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.15.1...2.15.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels