fix: unhandled on network drop when provider is not initialized #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cali93
approved these changes
Oct 16, 2024
| @@ -287,7 +287,7 @@ export class Relayer extends IRelayer { | |||
| } | |||
| } | |||
|
|
|||
| if (this.hasExperiencedNetworkDisruption || this.connected) { | |||
| if (this.provider.disconnect && (this.hasExperiencedNetworkDisruption || this.connected)) { | |||
There was a problem hiding this comment.
Would it be safer to use the optional chain operator or it's not needed ?
Suggested change
| if (this.provider.disconnect && (this.hasExperiencedNetworkDisruption || this.connected)) { | |
| if (this.provider?.disconnect && (this.hasExperiencedNetworkDisruption || this.connected)) { |
There was a problem hiding this comment.
no need as this.provider is {} if not yet initialized. Being {} is covered by other tests
bkrem
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
🙏
cc @alexsserban @tomiir this should fix the this.provider.disconnect is not a function issue that bubbles up on AppKit implementations
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed an unhandled exception in
provider.disconnect()whenprovideris not initialized andsubscribeToNetworkChangetriggered disconnect flowType of change
How has this been tested?
tests, dogfooding
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.