Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): resolve CI issues, npm audit fix, simplify dep management #208

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Jan 2, 2025

Context

  • The package-level lockfiles are redundant as the root level one is the authoritative lockfile, and we do not bundle lockfiles into our vendored packages, i.e. they're not consumed by projects installing these packages.
  • Upgrades the node version to v20, which resolves an environment resolution error for global.crypto, see: crypto is not defined when running on Node.js nextauthjs/next-auth#9814 (comment)
  • Fixes an issue where a broken projectId was inlined into the jsonrpc-ws and jsonrpc-provider tests, causing 403
  • Runs npm audit fix (i.e. all non-breaking fixes); this should auto close some existing renovatebot/dependabot PRs.

@bkrem
Copy link
Member Author

bkrem commented Jan 2, 2025

Provider test is still failing bc it relies on cloudflare-eth.com for the HTTP provider test and is being rate limited rn from me doing a lot of CI runs. Will rerun but passed locally for me.

Worked ✅

Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, curious why not node 22 ?

@bkrem bkrem force-pushed the chore/npm-audit-fix-2025-01 branch from 6e5c135 to ed20a88 Compare January 3, 2025 08:43
@bkrem
Copy link
Member Author

bkrem commented Jan 3, 2025

LGTM, curious why not node 22 ?

The ws implementation in node 22 seems to return different errors: https://github.com/WalletConnect/walletconnect-utils/actions/runs/12594957689/job/35103326396

I think we can upgrade to it easily for our tests but I don't want to touch actual source code or change test assertions in this PR.

@bkrem bkrem merged commit 4f53e25 into master Jan 3, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants