This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
[tests] Fix various spec tests #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
reviewed
May 20, 2020
gahaas
added a commit
to WebAssembly/bulk-memory-operations
that referenced
this pull request
Jun 4, 2020
The encoding of the table index in binary-leb128.wast is incorrect with the bulk-memory extensions, see #153. I saw and fixed the issue first in the reference types proposal (see WebAssembly/reference-types#95), but apparently it also exists here.
aheejin
pushed a commit
to aheejin/reference-types
that referenced
this pull request
Jun 5, 2020
This also adds `table.set` and `table.get` administrative instructions. Only `table.set` is used for now, but `table.copy` will use both.
gahaas
added a commit
to WebAssembly/bulk-memory-operations
that referenced
this pull request
Oct 12, 2020
The encoding of the table index in binary-leb128.wast is incorrect with the bulk-memory extensions, see #153. I saw and fixed the issue first in the reference types proposal (see WebAssembly/reference-types#95), but apparently it also exists here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues in the spec tests:
element segments.