-
Notifications
You must be signed in to change notification settings - Fork 43
Shorten all saturating instructions to "sat" #332
Comments
I always thought
|
Sounds fine to me, and I don't think we need to vote unless there are any concerns about this. |
Also update the test generate file, and regenerated all test files. Fixed WebAssembly#332.
Let's keep this issue open while we fix other WAT consumers too (e.g. binaryen, wabt). I'm also curious what we should do with the clang intrinsics. From the meeting last week, it sounds like we should batch these changes and do them all at once, is that right? |
Yes, batching changes is always nice for Binaryen and LLVM, and I think it's ok if they lag behind a bit on the renaming. I separately opened #342 to discuss further changes to the intrinsic names. |
Also update the test generation script, and regenerate all test files. Adressess #332 (not closing so other tools can also use it to track their rename progress).
wabt is done WebAssembly/wabt#1553, llvm and wasm_simd128.h is not up to date. |
This also anticipates a similar change in the LLVM builtins. See WebAssembly/simd#332
LLVM is updated, closing. |
The saturating instructions spell out the word "saturate".
I propose we shorten it to "sat" to be consistent with the truncation with saturation instructions, see https://webassembly.github.io/spec/core/text/instructions.html, e.g. 𝗂𝟨𝟦.𝗍𝗋𝗎𝗇𝖼_𝗌𝖺𝗍_𝖿𝟥𝟤_𝗌.
The text was updated successfully, but these errors were encountered: