-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return? #164
Comments
Hm, it's not in AstSemantics. I think it was before - but there have also been discussions of removing |
Strange, I still can see it in here: https://github.com/WebAssembly/design/blob/master/AstSemantics.md#control-flow-structures |
Yeah, there it is. I guess GitHub repository search doesn't actually work. :| |
Ah, I thought a previous discussion said we didn't have it anymore, I must have misunderstood. I guess we were just considering removing it. |
I actually went all the way and removed it from v8-native, since On Fri, Nov 6, 2015 at 8:49 AM, Alon Zakai [email protected] wrote:
|
Forget usability and say "readability". I have currently left it in my wasm-to-llvm prototype because I find it so much easier to read :) |
It is also still in the design repo, so I plan to add it back to v8-native. On Tue, Nov 10, 2015 at 6:21 PM, jcbeyler [email protected] wrote:
|
I don't have an opinion yet, but a few observations: It's in the design repo, but only because it predates statements=expressions, and the design hasn't been updated for that change in general. Return is non-compositional, for what that's worth. If the goal is just to make code more readable, an only slightly weaker effect could be achieved by using the existing label name syntax sugar and naming the return label "$return". Disassemblers could do this automatically if they wanted. |
My experience has been that expressing break as return from the outermost On Wed, Nov 11, 2015 at 12:40 AM, Dan Gohman [email protected]
|
Return stays, closing. |
For the record, I don't feel this is really settled yet; it's just something we're not really ready to explore while we have so many open questions about the nature of the text format(s). |
@sunfishcode, fair enough. I interpret this specific bug as being about the divergence between spec repo and design doc, which seems resolved for the time being. |
Merge upstream changes and small fix for S128
The
exports.wast
testcase has a "return" opcode. Is that part of the spec?The text was updated successfully, but these errors were encountered: