Test NaN bitpattern rules in a harness-independent way. #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests to check that the underlying platform follows the basic NaN bitpattern rules without depending on the handling of NaNs in the test harness or embedding environment.
Test that arithmetic with non-canonical NaN inputs at least produces an NaN with 1 in the most significant digit of the fraction field. And test that 0/0 produces a canonical NaN.
|
LGTM, but probably also has a dependency on WebAssembly/design#976. |
|
This change just makes the spec repo test what's already specified in the design repo more thoroughly, so I'm taking the liberty of merging, as it's desirable to keep the two in sync. If #976 leads to changes in the design, these tests can be updated accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests to check that the underlying platform follows the
basic NaN bitpattern rules without depending on the handling of NaNs
in the test harness or embedding environment.