Enable multi value by default #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi value was also merged into the spec, I think it is time to check this box.
|
@sbc100 what do you think of this? Perhaps we should discuss our policy on default features for all the tools again. |
|
We should be consistent with whatever policy we land on in WebAssembly/tool-conventions#158. Does wabt currently enable any non-MVP features by default? (e.g. non-trapping float to int?) |
|
Actually mutli-value was enabled back in #1405. It looks like these html documents all needed updating.. I think they are automatically generated. Perhaps close this PR and open a new one that updates them all? |
|
Oh wait, that page is manually maintained. lgtm.. plus we should probably update the other checkbox that are on by default these days. |
sbc100
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi value was merged into the spec almost a year ago, and all browsers support it. I think it is time to check the multi value checkbox by default.
Reference types were merged recently but support among browsers is limited at the moment, so I don't think it is time to check it by default yet.
Node stable does not support multi value, but this is a web based tool.