Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only strip files under the bin directory #275

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 29, 2022

Stripping other files (eg. *.a) doesn't seem the original intention and it sometimes has ill effects like breaking archive TOC.

Stripping other files (eg. *.a) doesn't seem the original intention
and it sometimes has ill effects like breaking archive TOC.
@TerrorJack
Copy link
Contributor

Another possible approach would be adding -DCMAKE_EXE_LINKER_FLAGS="-s" to the LLVM configure step, so the linker produces stripped executables directly and we can get rid of the strip logic altogether.

@sbc100
Copy link
Member

sbc100 commented Jan 3, 2023

Another possible approach would be adding -DCMAKE_EXE_LINKER_FLAGS="-s" to the LLVM configure step, so the linker produces stripped executables directly and we can get rid of the strip logic altogether.

Performing the stripped explicitly after the build feels more robust/obvious and makes sense to me from my old debian maintainer days.

@sbc100 sbc100 merged commit 3a3771d into WebAssembly:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants