Add thread spawn test #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
force-pushed
the
loganek/thread-spawn-test
branch
from
1f4952b to
a0421f8
Compare
|
Nice! Its great to see and end-to-end example like this. I will use this on the emscripten side to make sure we keep our API in sync. |
15 tasks
|
I'm merging this PR as there's no objection; feel free to open an issue if you have any comments regarding the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the tests I'm using for testing WAMR implementation; I thought it might be beneficial to others to push the test here as it's
almostlibc agnostic (used libc here only forassertandint64_t).I've implemented that in C as I don't think pure WAT implementation brings a lot more value here (although if that's what's preferred, I don't mind changing that). If that's merged, I'll also integrate the repository with wasi-testsuite so the test (and any other tests added to the repo) can be executed with other wasi tests.
The test here is rather simple but does a few checks; I'm open for suggestions so we can either extend this test or add few more tests to cover more functionality.