Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credential presentation from held credential to verifier #166

Merged
merged 11 commits into from
Dec 7, 2023

Conversation

pfeairheller
Copy link
Member

Addition of submitGrant that calls the correct endpoint to perform a credential grant.

Sample in single-issuer-holder.test.ts of using data from credentials/list to create a GRANT for presenting a held credential.

This fixes the grant methods to allow for granting from a held credential. I believe it supercedes #158

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3039ace) 81.21% compared to head (11b1d37) 81.36%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #166      +/-   ##
===============================================
+ Coverage        81.21%   81.36%   +0.15%     
===============================================
  Files               46       46              
  Lines             4137     4149      +12     
  Branches          1023     1030       +7     
===============================================
+ Hits              3360     3376      +16     
+ Misses             745      741       -4     
  Partials            32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! From the logs it looks like the failing integration test just needs a new keria image?

@pfeairheller
Copy link
Member Author

Great! From the logs it looks like the failing integration test just needs a new keria image?

Yup, building / publishing them now.

@pfeairheller
Copy link
Member Author

Looks like I also need some unit test coverage. I'm not happy with the arguments I added and will probably collapse them by using an object for each message being passed in. So instead of acdc and acdcAttachment, I'm going to change it to acdc that takes sad and atc.

@pfeairheller
Copy link
Member Author

Getting stuck in a mess. Some of the integration tests weren't fixed to run correctly with the "local" environment. Fixing that to see what else is going on with them.

pfeairheller and others added 11 commits December 6, 2023 19:03
…credential grant.

Sample in `single-issuer-holder.test.ts` of using data from credentials/list to create a GRANT for presenting a held credential.
Changed workflow for integration tests to pull image every time since our plan is to overwrite the dev tags on the images for development builds for KERIA / KERIpy
@pfeairheller pfeairheller merged commit c0727b6 into WebOfTrust:development Dec 7, 2023
5 checks passed
@pfeairheller pfeairheller deleted the feat-verifier branch December 7, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants