-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credential presentation from held credential to verifier #166
Add credential presentation from held credential to verifier #166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #166 +/- ##
===============================================
+ Coverage 81.21% 81.36% +0.15%
===============================================
Files 46 46
Lines 4137 4149 +12
Branches 1023 1030 +7
===============================================
+ Hits 3360 3376 +16
+ Misses 745 741 -4
Partials 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! From the logs it looks like the failing integration test just needs a new keria image?
Yup, building / publishing them now. |
Looks like I also need some unit test coverage. I'm not happy with the arguments I added and will probably collapse them by using an object for each message being passed in. So instead of |
Getting stuck in a mess. Some of the integration tests weren't fixed to run correctly with the "local" environment. Fixing that to see what else is going on with them. |
…credential grant. Sample in `single-issuer-holder.test.ts` of using data from credentials/list to create a GRANT for presenting a held credential.
Changed workflow for integration tests to pull image every time since our plan is to overwrite the dev tags on the images for development builds for KERIA / KERIpy
b1705fb
to
11b1d37
Compare
Addition of submitGrant that calls the correct endpoint to perform a credential grant.
Sample in
single-issuer-holder.test.ts
of using data from credentials/list to create a GRANT for presenting a held credential.This fixes the grant methods to allow for granting from a held credential. I believe it supercedes #158