Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dendro appearance #811

Merged
merged 15 commits into from
Jul 31, 2018
Merged

Bugfix/dendro appearance #811

merged 15 commits into from
Jul 31, 2018

Conversation

WeiqiNs
Copy link
Member

@WeiqiNs WeiqiNs commented Jul 28, 2018

Fix dendrogram plotly graph

  • Removed right and top orientation.
  • Added a padding so that most right leaf will not touch the border of the plot. (Note: The padding now will not go away when you zoom in and zoom out.)
  • Dynamically extend plot margins so that long label will not get cut off.

Below are two usage cases.

  • Left orientation
    screenshot from 2018-07-28 16-29-00
  • Bottom orientation
    screenshot from 2018-07-28 16-29-59

@codecov
Copy link

codecov bot commented Jul 28, 2018

Codecov Report

Merging #811 into master will increase coverage by 0.46%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   37.15%   37.61%   +0.46%     
==========================================
  Files          52       52              
  Lines        4288     4317      +29     
==========================================
+ Hits         1593     1624      +31     
+ Misses       2695     2693       -2
Impacted Files Coverage Δ
lexos/models/dendro_model.py 92.85% <94.59%> (+9.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91bb169...4f5711e. Read the comment docs.

@WeiqiNs WeiqiNs merged commit 83b52e0 into master Jul 31, 2018
@WeiqiNs WeiqiNs deleted the bugfix/dendro_appearance branch July 31, 2018 03:34
@mleblanc321
Copy link
Contributor

hmm, i'm testing DAZ and segment labels are being truncated/chopped? (using lexos3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants