-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1856 Campaign Alert Table Not Showing under Mobile Layout #1859
Fix #1856 Campaign Alert Table Not Showing under Mobile Layout #1859
Conversation
@wendyyuchensun cool! I can merge this now if you like, but if you want to take it further, it would be ideal to include more info in the mobile layout. The most useful thing would be to at least show the alert type. |
39d8826
to
5dbcde7
Compare
5ee486a
to
3b80c59
Compare
3b80c59
to
a7cb23f
Compare
Hi @ragesoss, I've added a new commit to include type column in mobile layout. However, CI failed. I think it's related to version of Node used in CI (v10.0.0), not this PR. I reproduced same error shown in CI logs by using Node 10.0.0 and running gulp related commands in my local environment (macOS/gulp 3.9.1). Using Node 8.11.1 works fine. Seems like someone bumped into similar problem: gulpjs/gulp#2162 |
@wendyyuchensun thanks! I'll look into the node/gulp issue soon, probably tomorrow. Did you try upgrading gulp to 4.0.0? |
Not yet. I'll see if I have time to try it out recently. I'll share the result here when I'm done. |
The nodejs 10 compatibility is sorted out now... lemme give this a try. |
Nice work @wendyyuchensun. Thanks! |
Fix #1856
The bug
The article column in alert table has a
desktop-only-tc
class, which hides the whole column under mobile layout.Since article column should be the only thing alert tables shows under mobile layout, that class makes the table looks like 'totally disappeared' when switches to mobile layout.
What I did
desktop-only-tc
class of article column.Result of fix (viewport width < 920px)
Let me know if there is any problem with this PR. Thanks for reviewing!