Fix issue 69 cmd with apostrophe #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated RSpec matchers to use newer expect syntax to replace should syntax.
On Ruby 2.0+ CGI.escapeHTML will escape single quotes to ' which breaks the WinRM web service. We pull out the rendered XML and unescape any single quotes before sending the request.
|
@sneal, @pmorton, Any chance we can get this ported back to 1.3 with a new gem release to address the issue above referenced by @juliandunn? We've mostly worked around it, but there are some cases that can still get people with knife plugins and we may also be missing other scenarios (e.g. non-English locales) that we haven't yet heard about. |
|
@adamedx I've been working on some minor bug fixes this past week and plan on releasing winrm 1.1.4 next week before I start working on some major changes to the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmorton @keiths-osc Fixes WinRM service errors when commands contain single quotes on Ruby 2.x.