tun: use add-with-carry in checksumNoFold() #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened with a fix for initial values.
This PR proposes a speedup for
checksumNoFold()
.Use parallel summation with native byte order per RFC 1071;
add-with-carry operation is used to add 4 words per operation.
Byteswap is performed before and after checksumming for compatibility with old
checksumNoFold()
.With this we get a 30-80% speedup in
checksum()
depending on packet sizes.Add unit tests with comparison to a per-word implementation and the old big-endian implementation.
Intel(R) Xeon(R) Silver 4210R CPU @ 2.40GHz
AMD EPYC 7352 24-Core Processor