Skip to content

Commit

Permalink
manager: pitfalls: cap virtio check to min 40 for Parallels
Browse files Browse the repository at this point in the history
It looks like Parallels forked NetKVM from Red Hat and changed the
versioning scheme, but kept the same driver name. So we skip the warning
for a floor of v40.

Signed-off-by: Jason A. Donenfeld <[email protected]>
  • Loading branch information
zx2c4 committed Oct 26, 2021
1 parent 3773020 commit dc5878b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion manager/pitfalls.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,10 @@ func pitfallVirtioNetworkDriver() {
if err != nil {
return
}
const minimumPlausibleVersion = 40 << 48
const minimumGoodVersion = (100 << 48) | (85 << 32) | (104 << 16) | (20800 << 0)
version := (uint64(fixedInfo.FileVersionMS) << 32) | uint64(fixedInfo.FileVersionLS)
if version >= minimumGoodVersion {
if version >= minimumGoodVersion || version < minimumPlausibleVersion {
return
}
log.Println("Warning: the VirtIO network driver (NetKVM) is out of date and may cause known problems; please update to v100.85.104.20800 or later")
Expand Down

0 comments on commit dc5878b

Please sign in to comment.