Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #169

Merged
merged 8 commits into from
Apr 15, 2020
Merged

Update docs #169

merged 8 commits into from
Apr 15, 2020

Conversation

mcallegari10
Copy link
Contributor

Description

  • Update README with the new props and functions, added some missing ones too
  • Update the LICENSE year
  • Create the types definition file. This is still a work in progress since it will be shipped with the new version but I need time to publish it to DefinitlyTyped

mcallegari10 added 2 commits April 13, 2020 14:55
Update Docs
ca7d977 
- update README with new props and dispatcher functions
- update year on LICENSE
add types definitions for the exported functions and component
9a88459
pabloferro
pabloferro suggested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@pabloferro pabloferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! just a few small details.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

For example, if you want to use a simple button to toggle the widget:
function MyApp() {
getCustomLaucher = (handleToggle) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to use a const here too.

Martín Callegari and others added 5 commits April 15, 2020 17:31
@mcallegari10 mcallegari10 merged commit 8076feb into 3.0 Apr 15, 2020
@mcallegari10 mcallegari10 deleted the update-docs branch April 15, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloferro pabloferro pabloferro approved these changes

@damfinkel damfinkel Awaiting requested review from damfinkel

Assignees

@pabloferro pabloferro

@damfinkel damfinkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcallegari10 @pabloferro @damfinkel