Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wpml-config.xml #3053

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Create wpml-config.xml #3053

merged 2 commits into from
Dec 19, 2024

Conversation

adamwoodnz
Copy link
Contributor

Adds a WPML config file for Polylang Pro, see comment.

See #2284

Adds a WPML config file for Polylang Pro, see #2284 (comment).

See #2284
Copy link
Collaborator

@jonathanbossenger jonathanbossenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamwoodnz
Copy link
Contributor Author

How do I test this please @jonathanbossenger?

@jonathanbossenger
Copy link
Collaborator

@adamwoodnz the way I've been testing it is to try and translate a lesson that's part of a module in a course.

In this comment, you'll see that when I try to translate the lesson, the relationship between the lesson and its parent module is broken.

After applying the XML config file, that relationship is retained after translation, see example of this in action here.

So essentially, when the XML file is in place, it should be possible to translate a lesson that's part of a module and course, without the relationships between the module and course being lost.

@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Dec 19, 2024

I've done some testing and I did observe some weirdness without the config, but I wasn't able to consistently reproduce your issue. Maybe the order of operations matters (I added the US lesson to a module, and then added a translation through Polylang UI), or maybe the config was cached when switching between prod and my sandbox. Anyway I will merge this and you can check the test site to make sure it's behaving.

@adamwoodnz adamwoodnz merged commit 9ac14d4 into trunk Dec 19, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the add/2284-wpml-config branch December 19, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants