Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update preview key location to match new schema" #17

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

matiasbenedetto
Copy link
Collaborator

@matiasbenedetto matiasbenedetto commented Feb 1, 2024

What?

Reverts #16

Why?

After removing the not needed preview key from the theme.json schema, we added some complexity to the font-collection.json schema that was revealed as unnecessary and promoting more complex code down the line, so in this other PR, rollsback part of the complexity added in the font-collection.json schema.

The changes of this revert PR are to match the latest version of the Gutenberg's font-collection.json schema.

Copy link
Collaborator

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Spot checked the updated json, looks correct
  • Loaded the collection json from this PR in the Site editor and browsing/installing fonts works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants