Updated/renamed tabs example #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together! Looks like our recent merges have caused some conflicts would you mind addressing those and I'll review the changes? |
|
Hi there,
After reflection, I realize it should probably also be wrapped with
useBlockProps().
Cheers,
Paul
…On Tue, Apr 5, 2022 at 9:59 AM Ryan Welcher ***@***.***> wrote:
Thanks for putting this together! Looks like our recent merges have caused
some conflicts would you mind addressing those and I'll review the changes?
—
Reply to this email directly, view it on GitHub
<#210 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLUZYLZ4RKSIYQV6O3OO2LVDRBNDANCNFSM5SFMA7QQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Superseded by #218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of the PR from @jsakas, based on a comment from @ryanwelcher about updating the PR according to the latest development.
This PR also catches up lerna to include more blocks, and fixes the mislabeled
package.jsonfor example 09.