-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Site Editor]: Add
delete
action for pages in navigation sidebar (#…
…51101) * [Site Editor]: Add `delete` action for pages in navigation sidebar * throw errors on delete and address feedback * close confrim dialog onRemove
- Loading branch information
1 parent
a450434
commit 375b16f
Showing
3 changed files
with
123 additions
and
5 deletions.
There are no files selected for viewing
71 changes: 71 additions & 0 deletions
71
packages/edit-site/src/components/page-actions/delete-page-menu-item.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useDispatch, useSelect } from '@wordpress/data'; | ||
import { decodeEntities } from '@wordpress/html-entities'; | ||
import { useState } from '@wordpress/element'; | ||
import { store as coreStore } from '@wordpress/core-data'; | ||
import { __, sprintf } from '@wordpress/i18n'; | ||
import { | ||
MenuItem, | ||
__experimentalConfirmDialog as ConfirmDialog, | ||
} from '@wordpress/components'; | ||
import { store as noticesStore } from '@wordpress/notices'; | ||
|
||
export default function DeletePageMenuItem( { postId, onRemove } ) { | ||
const [ isModalOpen, setIsModalOpen ] = useState( false ); | ||
const { createSuccessNotice, createErrorNotice } = | ||
useDispatch( noticesStore ); | ||
const { deleteEntityRecord } = useDispatch( coreStore ); | ||
const page = useSelect( | ||
( select ) => | ||
select( coreStore ).getEntityRecord( 'postType', 'page', postId ), | ||
[ postId ] | ||
); | ||
async function removePage() { | ||
try { | ||
await deleteEntityRecord( | ||
'postType', | ||
'page', | ||
postId, | ||
{}, | ||
{ throwOnError: true } | ||
); | ||
createSuccessNotice( | ||
sprintf( | ||
/* translators: The page's title. */ | ||
__( '"%s" deleted.' ), | ||
decodeEntities( page.title.rendered ) | ||
), | ||
{ | ||
type: 'snackbar', | ||
id: 'edit-site-page-removed', | ||
} | ||
); | ||
onRemove?.(); | ||
} catch ( error ) { | ||
const errorMessage = | ||
error.message && error.code !== 'unknown_error' | ||
? error.message | ||
: __( 'An error occurred while deleting the page.' ); | ||
|
||
createErrorNotice( errorMessage, { type: 'snackbar' } ); | ||
} finally { | ||
setIsModalOpen( false ); | ||
} | ||
} | ||
return ( | ||
<> | ||
<MenuItem onClick={ () => setIsModalOpen( true ) } isDestructive> | ||
{ __( 'Delete' ) } | ||
</MenuItem> | ||
<ConfirmDialog | ||
isOpen={ isModalOpen } | ||
onConfirm={ removePage } | ||
onCancel={ () => setIsModalOpen( false ) } | ||
> | ||
{ __( 'Are you sure you want to delete this page?' ) } | ||
</ConfirmDialog> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { DropdownMenu, MenuGroup } from '@wordpress/components'; | ||
import { moreVertical } from '@wordpress/icons'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import DeletePageMenuItem from './delete-page-menu-item'; | ||
|
||
export default function PageActions( { | ||
postId, | ||
className, | ||
toggleProps, | ||
onRemove, | ||
} ) { | ||
return ( | ||
<DropdownMenu | ||
icon={ moreVertical } | ||
label={ __( 'Actions' ) } | ||
className={ className } | ||
toggleProps={ toggleProps } | ||
> | ||
{ () => ( | ||
<MenuGroup> | ||
<DeletePageMenuItem | ||
postId={ postId } | ||
onRemove={ onRemove } | ||
/> | ||
</MenuGroup> | ||
) } | ||
</DropdownMenu> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
375b16f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 375b16f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5132456919
📝 Reported issues:
/test/e2e/specs/site-editor/style-book.spec.js