Skip to content

Commit

Permalink
e2e-test-utils-playwright: Increase timeout of site-editor selector (#…
Browse files Browse the repository at this point in the history 
…66672)

Co-authored-by: alexflorisca <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: ironprogrammer <[email protected]>
  • Loading branch information
@alexflorisca @youknowriad @ironprogrammer
4 people authored Dec 10, 2024
1 parent 8042535 commit 4020989
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export async function visitSiteEditor(

// Wait for the canvas loader to appear first, so that the locator that
// waits for the hidden state doesn't resolve prematurely.
await canvasLoader.waitFor( { state: 'visible' } );
await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } );

Check failure on line 57 in packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts

View workflow job for this annotation

GitHub Actions / Playwright - 8

[firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@firefox 

  1) [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions 
    TimeoutError: locator.waitFor: Timeout 60000ms exceeded.
    Call log:
      - waiting for locator('.edit-site-canvas-loader, .edit-site-canvas-spinner') to be visible


       at ../../../packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57

      55 | 		// Wait for the canvas loader to appear first, so that the locator that
      56 | 		// waits for the hidden state doesn't resolve prematurely.
    > 57 | 		await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } );
         | 		                   ^
      58 | 		await canvasLoader.waitFor( {
      59 | 			state: 'hidden',
      60 | 			// Bigger timeout is needed for larger entities, like the Large Post

        at Admin.visitSiteEditor (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57:22)
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:353:4

Check failure on line 57 in packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts

View workflow job for this annotation

GitHub Actions / Playwright - 8

[firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@firefox 

  1) [firefox] › editor/blocks/navigation-frontend-interactivity.spec.js:378:3 › Navigation block - Frontend interactivity › Submenus (Arrow setting) (@Firefox, @WebKit) › submenu click on the arrow interactions 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TimeoutError: locator.waitFor: Timeout 60000ms exceeded.
    Call log:
      - waiting for locator('.edit-site-canvas-loader, .edit-site-canvas-spinner') to be visible


       at ../../../packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57

      55 | 		// Wait for the canvas loader to appear first, so that the locator that
      56 | 		// waits for the hidden state doesn't resolve prematurely.
    > 57 | 		await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } );
         | 		                   ^
      58 | 		await canvasLoader.waitFor( {
      59 | 			state: 'hidden',
      60 | 			// Bigger timeout is needed for larger entities, like the Large Post

        at Admin.visitSiteEditor (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts:57:22)
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:353:4
await canvasLoader.waitFor( {
state: 'hidden',
// Bigger timeout is needed for larger entities, like the Large Post
Expand Down

1 comment on commit 4020989

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 4020989.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12259392578
📝 Reported issues:

Please sign in to comment.