improve type

WordPress · Oct 30, 2024 · 51e08fe · 51e08fe
1 parent d871796
commit 51e08fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/fields/src/fields/slug/slug-view.tsx b/packages/fields/src/fields/slug/slug-view.tsx
@@ -10,7 +10,7 @@ import type { BasePost } from '../../types';
 import { getSlug } from './utils';
 
 const SlugView = ( { item }: { item: BasePost } ) => {
-	const slug = item ? getSlug( item ) : '';
+	const slug = typeof item === 'object' ? getSlug( item ) : '';
 	const originalSlugRef = useRef( slug );
 
 	useEffect( () => {
@@ -21,7 +21,7 @@ const SlugView = ( { item }: { item: BasePost } ) => {
 
 	const slugToDisplay = slug || originalSlugRef.current;
 
-	return `${ slugToDisplay ?? '' }`;
+	return `${ slugToDisplay }`;
 };
 
 export default SlugView;
diff --git a/packages/fields/src/fields/slug/utils.ts b/packages/fields/src/fields/slug/utils.ts
@@ -8,7 +8,7 @@ import { cleanForSlug } from '@wordpress/url';
 import type { BasePost } from '../../types';
 import { getItemTitle } from '../../actions/utils';
 
-export const getSlug = ( item: BasePost ) => {
+export const getSlug = ( item: BasePost ): string => {
 	return (
 		item.slug || cleanForSlug( getItemTitle( item ) ) || item.id.toString()
 	);