USe more intuitive naming

packages/core-data/src/actions.js

@@ -7,7 +7,7 @@ import { v4 as uuid } from 'uuid';
 /**
  * WordPress dependencies
  */
-import { createAsyncRegistryAction } from '@wordpress/data';
+import { createRegistryAction } from '@wordpress/data';
 import apiFetch from '@wordpress/api-fetch';
 import { addQueryArgs } from '@wordpress/url';
 
@@ -224,7 +224,7 @@ export function* deleteEntityRecord( kind, name, recordId, query ) {
  *
  * @return {Object} Action object.
  */
-export const editEntityRecord = createAsyncRegistryAction(
+export const editEntityRecord = createRegistryAction(
 	( { select } ) => async ( kind, name, recordId, edits, options = {} ) => {
 		const entity = select( 'core', 'getEntity', kind, name );
 		if ( ! entity ) {
@@ -282,36 +282,36 @@ export const editEntityRecord = createAsyncRegistryAction(
  * Action triggered to undo the last edit to
  * an entity record, if any.
  */
-export const undo = createAsyncRegistryAction( ( { select } ) => () => {
+export const undo = createRegistryAction( ( { select, yieldAction } ) => () => {
 	const undoEdit = select( 'core' ).getUndoEdit();
 	if ( ! undoEdit ) {
 		return;
 	}
-	return {
+	yieldAction( {
 		type: 'EDIT_ENTITY_RECORD',
 		...undoEdit,
 		meta: {
 			isUndo: true,
 		},
-	};
+	} );
 } );
 
 /**
  * Action triggered to redo the last undoed
  * edit to an entity record, if any.
  */
-export const redo = createAsyncRegistryAction( ( { select } ) => () => {
+export const redo = createRegistryAction( ( { select, yieldAction } ) => () => {
 	const redoEdit = select( 'core' ).getRedoEdit();
 	if ( ! redoEdit ) {
 		return;
 	}
-	return {
+	yieldAction( {
 		type: 'EDIT_ENTITY_RECORD',
 		...redoEdit,
 		meta: {
 			isRedo: true,
 		},
-	};
+	} );
 } );
 
 /**
@@ -332,7 +332,7 @@ export function __unstableCreateUndoLevel() {
  * @param {Object}  options                    Saving options.
  * @param {boolean} [options.isAutosave=false] Whether this is an autosave.
  */
-export const saveEntityRecord = createAsyncRegistryAction(
+export const saveEntityRecord = createRegistryAction(
 	( { select, dispatch, yieldAction } ) => async (
 		kind,
 		name,
@@ -614,7 +614,7 @@ export const saveEntityRecord = createAsyncRegistryAction(
  * @param {Object} recordId ID of the record.
  * @param {Object} options  Saving options.
  */
-export const saveEditedEntityRecord = createAsyncRegistryAction(
+export const saveEditedEntityRecord = createRegistryAction(
 	( { select, dispatch } ) => ( kind, name, recordId, options ) => {
 		if (
 			! select( 'core' ).hasEditsForEntityRecord( kind, name, recordId )

packages/core-data/src/resolvers.js

@@ -8,7 +8,7 @@ import { find, includes, get, hasIn, compact, uniq } from 'lodash';
  */
 import { addQueryArgs } from '@wordpress/url';
 import deprecated from '@wordpress/deprecated';
-import { controls, createAsyncRegistryAction } from '@wordpress/data';
+import { controls, createRegistryAction } from '@wordpress/data';
 import { apiFetch } from '@wordpress/data-controls';
 import triggerFetch from '@wordpress/api-fetch';
 
@@ -25,7 +25,7 @@ import { ifNotResolved, getNormalizedCommaSeparable } from './utils';
  * @param {Object|undefined} query Optional object of query parameters to
  *                                 include with request.
  */
-export const getAuthors = createAsyncRegistryAction(
+export const getAuthors = createRegistryAction(
 	( { dispatch } ) => async ( query ) => {
 		const path = addQueryArgs(
 			'/wp/v2/users/?who=authors&per_page=100',
@@ -41,7 +41,7 @@ export const getAuthors = createAsyncRegistryAction(
  *
  * @param {number} id The author id.
  */
-export const __unstableGetAuthor = createAsyncRegistryAction(
+export const __unstableGetAuthor = createRegistryAction(
 	( { dispatch } ) => async ( id ) => {
 		const path = `/wp/v2/users?who=authors&include=${ id }`;
 		const users = await triggerFetch( { path } );
@@ -52,7 +52,7 @@ export const __unstableGetAuthor = createAsyncRegistryAction(
 /**
  * Requests the current user from the REST API.
  */
-export const getCurrentUser = createAsyncRegistryAction(
+export const getCurrentUser = createRegistryAction(
 	( { dispatch } ) => async () => {
 		const currentUser = await triggerFetch( { path: '/wp/v2/users/me' } );
 		return dispatch( 'core' ).receiveCurrentUser( currentUser );
@@ -68,7 +68,7 @@ export const getCurrentUser = createAsyncRegistryAction(
  * @param {Object|undefined} query Optional object of query parameters to
  *                                 include with request.
  */
-export const getEntityRecord = createAsyncRegistryAction(
+export const getEntityRecord = createRegistryAction(
 	( { yieldAction, select, dispatch } ) => async (
 		kind,
 		name,
@@ -167,7 +167,7 @@ export const getEditedEntityRecord = ifNotResolved(
  * @param {string}  name   Entity name.
  * @param {Object?} query  Query Object.
  */
-export const getEntityRecords = createAsyncRegistryAction(
+export const getEntityRecords = createRegistryAction(
 	( { yieldAction, dispatch } ) => async ( kind, name, query = {} ) => {
 		const entities = await yieldAction( getKindEntities( kind ) );
 		const entity = find( entities, { kind, name } );
@@ -262,7 +262,7 @@ getEntityRecords.shouldInvalidate = ( action, kind, name ) => {
 /**
  * Requests the current theme.
  */
-export const getCurrentTheme = createAsyncRegistryAction(
+export const getCurrentTheme = createRegistryAction(
 	( { dispatch } ) => async () => {
 		const activeThemes = await triggerFetch( {
 			path: '/wp/v2/themes?status=active',
@@ -274,7 +274,7 @@ export const getCurrentTheme = createAsyncRegistryAction(
 /**
  * Requests theme supports data from the index.
  */
-export const getThemeSupports = createAsyncRegistryAction(
+export const getThemeSupports = createRegistryAction(
 	( { dispatch } ) => async () => {
 		const activeThemes = await triggerFetch( {
 			path: '/wp/v2/themes?status=active',
@@ -290,7 +290,7 @@ export const getThemeSupports = createAsyncRegistryAction(
  *
  * @param {string} url   URL to get the preview for.
  */
-export const getEmbedPreview = createAsyncRegistryAction(
+export const getEmbedPreview = createRegistryAction(
 	( { dispatch } ) => async ( url ) => {
 		try {
 			const embedProxyResponse = await triggerFetch( {
@@ -313,7 +313,7 @@ export const getEmbedPreview = createAsyncRegistryAction(
  * @deprecated since 5.0. Callers should use the more generic `canUser()` selector instead of
  *            `hasUploadPermissions()`, e.g. `canUser( 'create', 'media' )`.
  */
-export const hasUploadPermissions = createAsyncRegistryAction(
+export const hasUploadPermissions = createRegistryAction(
 	( { dispatch } ) => async () => {
 		deprecated( "select( 'core' ).hasUploadPermissions()", {
 			alternative: "select( 'core' ).canUser( 'create', 'media' )",
@@ -331,7 +331,7 @@ export const hasUploadPermissions = createAsyncRegistryAction(
  * @param {string}  resource REST resource to check, e.g. 'media' or 'posts'.
  * @param {?string} id       ID of the rest resource to check.
  */
-export const canUser = createAsyncRegistryAction(
+export const canUser = createRegistryAction(
 	( { dispatch } ) => async ( action, resource, id ) => {
 		const methods = {
 			create: 'POST',

packages/data/src/factory.js

@@ -83,8 +83,8 @@ export function createRegistryControl( registryControl ) {
 /**
  * @TODO Documentation
  */
-export function createAsyncRegistryAction( callback ) {
+export function createRegistryAction( callback ) {
 	const wrapper = ( ...args ) => callback( wrapper.registryArgs )( ...args );
-	wrapper.isAsyncRegistryAction = true;
+	wrapper.isRegistryAction = true;
 	return wrapper;
 }

packages/data/src/index.js

@@ -26,7 +26,7 @@ export { createRegistry } from './registry';
 export {
 	createRegistrySelector,
 	createRegistryControl,
-	createAsyncRegistryAction,
+	createRegistryAction,
 } from './factory';
 export { controls } from './controls';
 export { default as createReduxStore } from './redux-store';

packages/data/src/promise-middleware.js

@@ -11,7 +11,7 @@ import isPromise from 'is-promise';
 const promiseMiddleware = () => ( next ) => ( action ) => {
 	if ( isPromise( action ) ) {
 		return action.then( ( resolvedAction ) => {
-			if ( action.isAsyncAction ) {
+			if ( action.isRegistryAction ) {
 				return resolvedAction;
 			} else if ( resolvedAction ) {
 				return next( resolvedAction );

packages/data/src/redux-store/index.js

@@ -357,7 +357,7 @@ function mapResolvers( resolvers, selectors, store, resolversCache ) {
 }
 
 function mapRegistryAsyncAction( action, store ) {
-	if ( action.isAsyncRegistryAction && ! action.registryArgs ) {
+	if ( action.isRegistryAction && ! action.registryArgs ) {
 		action.registryArgs = {
 			dispatch: dataDispatch,
 			select: dataSelect,