Update message logic to handle translations

WordPress · Feb 28, 2024 · 8741ca9 · 8741ca9
1 parent 142107e
commit 8741ca9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 15 deletions.
diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -351,11 +351,13 @@ export function ImageEdit( {
 					!! metadata?.bindings?.url &&
 					( ! blockBindingsSource ||
 						blockBindingsSource?.lockAttributesEditing ),
-				lockUrlControlsMessage: sprintf(
-					/* translators: %s: Label of the bindings source if exists */
-					__( 'Connected to %s' ),
-					blockBindingsSource?.label || __( 'dynamic data' )
-				),
+				lockUrlControlsMessage: blockBindingsSource?.label
+					? sprintf(
+							/* translators: %s: Label of the bindings source. */
+							__( 'Connected to %s' ),
+							blockBindingsSource.label
+					  )
+					: __( 'Connected to dynamic data' ),
 			};
 		},
 		[ isSingleSelected ]

diff --git a/packages/block-library/src/image/image.js b/packages/block-library/src/image/image.js
@@ -456,20 +456,24 @@ export default function Image( {
 					!! altBinding &&
 					( ! altBindingSource ||
 						altBindingSource?.lockAttributesEditing ),
-				lockAltControlsMessage: sprintf(
-					/* translators: %s: Label of the bindings source if exists */
-					__( 'Connected to %s' ),
-					altBindingSource?.label || __( 'dynamic data' )
-				),
+				lockAltControlsMessage: altBindingSource?.label
+					? sprintf(
+							/* translators: %s: Label of the bindings source. */
+							__( 'Connected to %s' ),
+							altBindingSource.label
+					  )
+					: __( 'Connected to dynamic data' ),
 				lockTitleControls:
 					!! titleBinding &&
 					( ! titleBindingSource ||
 						titleBindingSource?.lockAttributesEditing ),
-				lockTitleControlsMessage: sprintf(
-					/* translators: %s: Label of the bindings source if exists */
-					__( 'Connected to %s' ),
-					titleBindingSource?.label || __( 'dynamic data' )
-				),
+				lockTitleControlsMessage: titleBindingSource?.label
+					? sprintf(
+							/* translators: %s: Label of the bindings source. */
+							__( 'Connected to %s' ),
+							titleBindingSource.label
+					  )
+					: __( 'Connected to dynamic data' ),
 			};
 		},
 		[ clientId, isSingleSelected, metadata?.bindings ]